example: publish example on how to run cfn-lint

org-formation / org-formation-cli

Better than landingzones!

MIT License

1.4k stars 129 forks source link

example: publish example on how to run cfn-lint #132

Open OlafConijn opened 3 years ago

OlafConijn commented 3 years ago

put together an example on how to run cfn-lint / cfn-guard on org-formation builds.

nbaillie commented 2 years ago

Are there any plan to support a cloud-formation registry resource schemas definition for org-formation. so that we can perhaps use that with cfn-lint.

OlafConijn commented 2 years ago

hi @nbaillie

org-formation allows you to register types into the cloud-formation resource registry. the organization.yml however is not being executed/processed by CloudFormation. the intention behind this issue was to document something along the lines of:

//print tasks as cloudformation (after having processed the org-formation directives)
org-formation print-tasks ./organization-tasks.yml 

//install lint & run lint
pip install cfn-lint
cfn-lint \"./.printed-stacks/**/*.yaml\" -i W2001,E3001,E1019,W1020,W2509,E3021,E1010

the warnings here are to be expected (most likely false negatives)

did you have something else in mind with cloud-formation registry resource schemas?

thanks

nbaillie commented 2 years ago

Thanks for getting back to me. I had not looked at this in detail but had a thought..

we are seeing this issue: 3001 Invalid or unsupported Type Community::SSO::AssignmentGroup for resource AssignmentGroup in us-east-1

From cfn-lint issue and readme

I had seen that you can do:

-s, --registry-schemas
one or more directories of [CloudFormation Registry](https://aws.amazon.com/blogs/aws/cloudformation-update-cli-third-party-resource-support-registry/) [Resource Schemas](https://github.com/aws-cloudformation/aws-cloudformation-resource-schema/)

The thought was would it help the lint if we had the schema available.