org-formation / org-formation-cli

Better than landingzones!
MIT License
1.4k stars 129 forks source link

fix: Perform-tasks fails when creating/updating stacks with large templates to 2+ regions #569 #570

Closed kuggis closed 1 month ago

kuggis commented 1 month ago

Fixes org-formation/org-formation-cli#569

A new S3Client needs to be constructed whenever the template is uploaded to a new region. This isn't currently happening because region is not being passed as an argument to GetCredentialProviderWithRoleAssumptions when building the cacheKey within the GetS3Service function. This results in GetS3Service not seeing the request as a new cacheKey and the first S3Client is reused when it should not be.