org-formation / org-formation-cli

Better than landingzones!
MIT License
1.41k stars 131 forks source link

[Feature] Support for Alternate Contacts on Account resource #585

Open yannickvr opened 1 month ago

yannickvr commented 1 month ago

Subject of the issue

The OC::ORG::Account should support both Alternate Contacts and NonDefaultRegions. An issue for the latter was recently opened.

Steps to reproduce

Reference: https://docs.aws.amazon.com/accounts/latest/reference/manage-acct-update-contact-alternate.html#manage-acct-update-contact-alternate-orgs

Expected behaviour

  ProductionAccount:
    Type: OC::ORG::Account
    Properties:
      RootEmail: production@myorg.com
      AccountName: Production Account
      Tags:
        budget-alarm-threshold: '2500'
        account-owner-email: my@email.com
      Contacts:
        Billing:
          FullName: Jeff Bezos
          Title: Head of Everything
          Email: jeff@amazon.com
          Phone: +12345676890
        Operations:
          FullName: Jeff Bezos
          Title: Head of Everything
          Email: jeff@amazon.com
          Phone: +12345676890
        Security:
          FullName: Jeff Bezos
          Title: Head of Everything
          Email: jeff@amazon.com
          Phone: +12345676890

Each contact type (Billing, Operations, Security) is optional, but the properties are all required.

Actual behaviour

Not Supported

OlafConijn commented 2 weeks ago

NonDefaultRegions sounds like a good idea!

for contacts i would advice to use the community cloudformation type https://github.com/org-formation/aws-resource-providers/blob/master/account/alternate-contact/example.yml