org-id / register

A register of organisation identifier lists
Other
25 stars 28 forks source link

Create lu-rcs.json #517

Closed titiolukole closed 1 year ago

titiolukole commented 1 year ago

@kd-ods Hi Kadie, hope you are well. Yes please I am going to need some support on what needs to be changed. Not sure if it has been done correctly.

kd-ods commented 1 year ago

Hi @titiolukole - It looks like you've accepted my suggestions where I made them. But for the unresolved requests, you'll need to edit the json file again. So open the 'Files changed' tab (preferably in a separate tab so you can still refer to my comments) and click on the three dots at the top right of the files content to choose the 'Edit file' option. You'll then be able to edit the json by hand. See the 'Addressing review comments on a GitHub pull request' section of the guidance doc (which I've just added a bit to).

Email me if you need to go through this on a call.