2024 Updates from gov-id-finder

org-id / register

A register of organisation identifier lists

Other

25 stars 28 forks source link

2024 Updates from gov-id-finder #572

Closed markbrough closed 3 months ago

markbrough commented 3 months ago

Updates to COA codelists from Gov ID Finder

Includes:

Updates to a range of codes to ensure they include leading zeroes, where relevant
Removal of whitespace before and after codes
Added codes for: Benin, Botswana, Congo (Rep.), Equatorial Guinea, Morocco, Namibia, Nigeria, Philippines, Swaziland, South Africa
Removed codes for: Cambodia, Kyrgyzstan, Tajikistan - these are not available on gov-id-finder because there were issues with the source data
Names of Netherlands and Turkey have been updated

kd-ods commented 3 months ago

Thanks, @markbrough.

@siwhitehouse, @IsabelBirds - would it be useful to have someone from the IATI support desk review this pull request? Then I can do a final check.

emmajclegg commented 3 months ago

@kd-ods - I'm happy to have a look at this Monday, just wanted to sense-check what you think is most useful for us to review from the support perspective? (i.e. are we looking at the research/source data or just making sure we understand how to use these codes for IATI)

kd-ods commented 3 months ago

...or just making sure we understand how to use these codes for IATI

I think that's the critical thing, @emmajclegg. Plus going through the edits to check that they read ok. I'll assign to you to review. Ping me here when you're done.

emmajclegg commented 3 months ago

@kd-ods - I've gone through the edited lists and compared against the equivalent https://gov-id-finder.codeforiati.org/ pages. All looks good apart from minor edits to the BJ-COA and CI-COA example identifiers format (see my committed changes above). I'm not sure if I've submitted these as part of the review or not, apologies, but let me know anything else needed

kd-ods commented 3 months ago

Hi @markbrough.

Could you please take a look at the two commits from emmajclegg (bj-coa.json and ci-coa.json) and let me know if the edits are correct or whether it's just that the https://gov-id-finder.codeforiati.org/ pages haven't been updated yet.

Thanks!

markbrough commented 3 months ago

Hi @kd-ods I think the changes look fine! I am not sure why they weren't already in the PR though -- this was automatically generated from this file. But I think this PR is good to go as is.