search

org-noter / org-noter

Emacs document annotator, using Org-mode
GNU General Public License v3.0
165 stars 19 forks source link

Tab support #76

Open acosmicjoke opened 11 months ago

acosmicjoke commented 11 months ago

Org-noter forces opening a new frame for every ongoing noter session. I remember that a couple of years ago, I could open separate noter sessions in different emacs tabs without problem. That functionality seems to have been removed at some point. After a rudimentary browsing of the source code, I couldn't find an easy way to hack it back. Are there any plans to bring tab support back? It would be very welcome because I often have 3-4 open sessions at a time and the frames quickly overclutter my workspace.

petermao commented 10 months ago

Sorry, I don't use tabs. Can you bisect the tree and find the commit where tabs stop working for you? Since we took over maintenance, I don't recall removing any major features like that.

dmitrym0 commented 3 months ago

There is org-noter-always-create-frame:

"Create a new frame for each document session. When non-nil, org-noter will always create a new frame for the session. When nil, it will use the selected frame if it does not belong to any other session."

The behaviour is consistent with the doc string. When set to nil, the first document opens in the existing frame/tab, but the subsequent org-noter invocations open up a new frame.

I dont know why separate frame is required per org-noter, whether it's a limitation or simply design choice.

Happy to accept PRs, marking it as improvement.

dmitrym0 commented 3 months ago

There's an open PR for this issue, if anyone's willing to take a peek: https://github.com/org-noter/org-noter/pull/72/