search

org-roam / org-roam-bibtex

Org Roam integration with bibliography management software
GNU General Public License v3.0
568 stars 47 forks source link

Don't hard set the value of org-ref-notes-function #173

Closed bigodel closed 2 years ago

bigodel commented 3 years ago

as referenced in #172, more specifically in 1. of this comment.

myshevchuk commented 3 years ago

it would just be the case of storing the value of the variable in another variable and resetting it when the mode is unloaded, right?

Basically yes, just the edge case when Org-ref is not loaded yet must be taken into account. ORB redefines org-ref-notes-function in org-roam-bibtex-mode, it is perfectly legitimate not to have Org-ref loaded yet, unlike issue #172.

bigodel commented 3 years ago

Basically yes, just the edge case when Org-ref is not loaded yet must be taken into account. ORB redefines org-ref-notes-function in org-roam-bibtex-mode, it is perfectly legitimate not to have Org-ref loaded yet, unlike issue #172.

ok great, will try to solve it in a PR.

myshevchuk commented 2 years ago

This is not longer relevant for Org-ref v3, but the provided fix is general and also works for Org-ref v2 for those who still use the old version.