search

org-roam / org-roam-bibtex

Org Roam integration with bibliography management software
GNU General Public License v3.0
568 stars 47 forks source link

Remove org-ref package requires #201

Closed bdarcus closed 2 years ago

bdarcus commented 3 years ago

I decided to open this as a draft PR. It includes two commits ATM; to:

  1. to replace org-ref in package-requires withorg-mode "9.5"` (though maybe better to just remove it?)
  2. comments, prefaced with "BD ", on the rest of the code of what I think would be required to adapt ORB to org-cite.

I was thinking could be a basis of discussion, and I could drop the second commit if you wanted to remove the org-ref requirement in the meantime.

Follow processors?

The most interesting question is WTD about a possible follow processor, which is the UI that would integrate with org-open-at-point.

EDIT: actually, there are two questions; whether to do one (or more), and for what targets? I was assuming citations here, but could also be note links or some such.

For sure you could do an ORB one.

But I wonder if we could find a way to have your action extension capability available in other obvious follow processors:

  1. bibtex-actions has one for embark-act
  2. org-ref-cite has a hydra
  3. I think @tmalsburg is working on one for helm-bibtex, I believe using helm actions

For 1, I have an embark "target-finder" for org-cite citations and citation-references, so I am pretty sure all that is required is to write your own keymap and register that with embark.

(add-to-list 'embark-keymap-alist '(oc-citation . oc-orb-map))

That should expose the commands in embark-act, along with any other commands registered with that oc-citation category.

For 2, see https://github.com/jkitchin/org-ref-cite/issues/4.

bdarcus commented 3 years ago

John says of org-ref-cite:

I rewrote the hydra code which should address this. You can use `defhydra+' to extend a hydra.

bdarcus commented 3 years ago

FYI, I reverted the comment commit here, so it's just removing the hard dependency on org-ref.

bdarcus commented 2 years ago

Org-ref v3 removes the ivy and helm dependencies, so it less problematic to require in orb.

I'll close this then.

chuxubank commented 2 years ago

I don't think this pr should be closed. We should based on the fact that if we can use this package without org-ref, then org-ref is not a hard dependency of org-roam-biblatex, and should be moved to the soft dependencies (maybe add citar as well) and let the user to choose which package to use.

There are some jobs to be done to make all the functions work with citar, eg. orb-note-actions, but in my use cases, it just works good enough, as I mainly use the orb-edit-note.

bdarcus commented 2 years ago

I don't think this pr should be closed.

Yeah, I guess I agree :-)

In related news, I removed the bibtex-completion dependency from citar in the past few days.

myshevchuk commented 2 years ago

This has been fixed in 948ff0922237f78070ab4c9062a4376f00dfa0a5.