org-roam / org-roam-bibtex

Org Roam integration with bibliography management software
GNU General Public License v3.0
565 stars 47 forks source link

Fix caching of org-ref v3 format refs #233

Closed xzz53 closed 2 years ago

xzz53 commented 2 years ago

At present, leading & from org-ref v3 format cites is included into orb-notes-cache keys as-is, breaking orb-note-exists-p and notes-related actions in helm-bibtex. Fix this by stripping leading & from refs when building the cache.

myshevchuk commented 2 years ago

At present, leading & from org-ref v3 format cites is included into orb-notes-cache keys as-is

Hi, that's strange. I cannot confirm this. ORB retrieves the keys from Org-roam database. The keys are normalized by Org-roam using Org-ref functions before they are put into the database. Maybe you have a fairly outdated version of Org-roam before Org-ref v3 support?

xzz53 commented 2 years ago

Updating my month-old org-roam installation to master has fixed the issue. Sorry for the noise.

myshevchuk commented 2 years ago

No problem!