Added blacklist feature to tag filter.

org-roam / org-roam-server

A Web Application to Visualize the Org-Roam Database

MIT License

639 stars 51 forks source link

Added blacklist feature to tag filter. #52

Closed natask closed 4 years ago

natask commented 4 years ago

implements #48

goktug97 commented 4 years ago

I will look into it as soon as I got time. Sorry, couldn't replied to your #48 issue.

Can you use camelCase in variable names.
Can you reindent #reload-button {
.darkmode .select2-container--default .select2-selection--multiple .select2-selection__choice is already present can you remove it from your PR.
Please format the code using indent-region

natask commented 4 years ago

quick question, what is the rational for JSON.parsing and JSON.Stringifying internal objects like filter?

goktug97 commented 4 years ago

To search the set using the string hash not with an object hash. When you construct a javascript object using the selected dropdown values it will be unique but if you use a string it will have the same hash value with the previous stringifyed object. I don’t know if there is a better solution but this is simple and works without a problem

natask commented 4 years ago

I think it works quite well now. I am now trying to add so that a default whitelist and blacklist can be configured from emacs. other variables configuring preview on by default or default list type can configured as well with the same system. When I have time, I am planning on looking at how information is being passed from emacs side to this application and pass default variables on startup and reload. what do you think?

goktug97 commented 4 years ago

Thanks for the PR

EDIT: Please don't add your defaults to the PRs