organicmaps / organicmaps.github.io

Official Organic Maps website source code. Please contribute your translations!
Apache License 2.0
35 stars 34 forks source link

Prettify md/scss and update dependencies #168

Closed meenbeese closed 12 months ago

meenbeese commented 12 months ago

I ran npm i && npm run format and npm run upgrade to fix linting and update a few deps.

biodranik commented 12 months ago

@rtsisyk did it break po4a?

@meenbeese did you test po4a localization tool? What caused so many format changes? Is it possible to avoid replacement somehow?

meenbeese commented 12 months ago

did you test po4a localization tool? What caused so many format changes? Is it possible to avoid replacement somehow?

No, how can I test that? I just did the prettify as suggested. I don't see why we should try to avoid the replacements.

meenbeese commented 12 months ago

I tried with the latest version from master but it still produces the same result. And I didn't set up any different config for the formatter either, just using the default one.

As this is not especially important, I am just closing this PR to focus on more important issues that need to be resolved. Nearly all fixes and formatting issues have already been fixed. The only formatting critical for me is this line 117 in the sass/main.scss:

@media (width <= 768) {

As zola serve refuses to compile for me when it is as such. I have to change it to:

@media (max-width: 768) {

Which I had previously did in my last merged PR but it was reverted when you ran your formatter. How can we solve this?

biodranik commented 12 months ago
  1. Please avoid merge commits and always use rebase. You may need to practice a bit to better understand it. It is required in our git workflows.
  2. I don't have any build issues with zola related to scss. What is your zola version? Could it be that you have some conflicting global npm packages installed that influence the behavior of the formatter and scss transpiler?
meenbeese commented 12 months ago
  1. Please avoid merge commits and always use rebase. You may need to practice a bit to better understand it. It is required in our git workflows.

Thanks, I will try to explore rebase a bit more.

  1. I don't have any build issues with zola related to scss. What is your zola version?

My zola version is 0.16.1

Could it be that you have some conflicting global npm packages installed that influence the behavior of the formatter and scss transpiler?

I do have Prettier installed which may be the culprit behind the formatting changes but that doesn't explain the scss compiling error.

biodranik commented 12 months ago
✗ zola --version
zola 0.17.2

@meenbeese Please install the latest zola version and check if there is still that error. And share the full error log.

meenbeese commented 12 months ago

I can confirm that updating the zola version to 0.17.2 solved the error completely. Maybe we should document this in the README? I was planning on improving the README anyway sometime.

biodranik commented 12 months ago

You can clarify there that we're using the latest zola.