Closed Mr-Mime closed 1 year ago
I'm not sure that greyish background is better. Contrast may be tuned by reducing the font brightness, instead of increasing the background brightness, which makes more stress to (at least my) eyes. What do you think?
In the article, they compare pure black bg with pure white text. What about reducing the text brightness a bit?
I personally prefer pure black, it is less painful for the eyes in the dark. But I'm ok to try the same color as GitHub is using.
Can you please sign your commit to pass DCO check?
Latest commit: |
e4edd1e
|
Status: | ✅ Deploy successful! |
Preview URL: | https://104f9738.organicmaps.pages.dev |
Branch Preview URL: | https://improved-darkmode-background.organicmaps.pages.dev |
Fixed the DCO.
However I do not want to force you to accept this new color. Else next week some one creates a PR saying "I prefer the background color to be XY" and so on :D
Hope you understand what you mean.
An idea would be to allow the user to choose a "pure black" or "light dimm" theme. However I think this would be more work than it outputs...
Right now the background is pure black.
This change makes it to a light grey and thereby reduces the contrast. This helps when reading.
It is good, as the text color already is a "darker" white.
Just thought I'll create the PR let me know what you think
Current production:
With new background: