organicmaps / organicmaps

🍃 Organic Maps is a free Android & iOS offline maps app for travelers, tourists, hikers, and cyclists. It uses crowd-sourced OpenStreetMap data and is developed with love by MapsWithMe (MapsMe) founders and our community. No ads, no tracking, no data collection, no crapware. Please donate to support the development!
https://organicmaps.app
Apache License 2.0
9.89k stars 951 forks source link

Pedestrian multipolygon not rendered if area=yes is missing #2393

Open dvdmrtnz opened 2 years ago

dvdmrtnz commented 2 years ago

If a multipolygon is tagged as highway=pedestrian and area=yes, it gets rendered correctly:

https://www.openstreetmap.org/relation/1405820#map=18/42.80863/-1.66987

https://omaps.app/8n_T4XVT7d

However, if the multipolygon is tagged as highway=pedestrian without the area=yes tagging, it doesn’t get rendered at all:

https://www.openstreetmap.org/relation/13847953#map=19/42.81189/-1.65802

https://omaps.app/4n_T5DiNfz

This seems like a bug. The wiki says that area=yes is not needed for multipolygons.

for relations area is not used - multipolygons are also marking objects as an area, so area=yes on them would be redundant

https://wiki.openstreetmap.org/wiki/Key:area

biodranik commented 2 years ago

@vng can you please take a look?

vng commented 2 years ago

Also linear Features are created for area pedestrian/footway/service OSM ways now, while for relations are not. In general, do we need linear Features for area highway objects at all?

Here is a good complicated area example

biodranik commented 2 years ago

At a minimum, areas should be routable and searchable. Ideally also visible. What was the reason to create linear features for pedestrian/footway/service ways?

vng commented 2 years ago

Because making areas routabe is a complicated problem.

pastk commented 1 year ago

A linear pedestrian way around an areal square doesn't look very good, but is needed for the routing indeed.

A related case is a closed way waterway=dam which is also represented in OM as both linear and area features: 2023-06-12-181144_1366x768_scrot

It doesn't look good at all (path captions on dam borders). Ideally we would create an areal feature here only. But how to distinguish with the pedestrian area case? A hardcoded exception?

More common cases are like closed way amenity=school barrier=fence. We create an areal schoolgrounds and a linear fence - sounds fine.

And is it possible there is a waterway=dam barrier=wall?

pastk commented 1 year ago

Also linear Features are created for area pedestrian/footway/service OSM ways now, while for relations are not.

An example of multipolygon highway-pedestrian-area, for which OM doesn't create a linear feature: https://www.openstreetmap.org/relation/10950251#map=18/48.85260/2.36877 2023-06-14-192129_1366x768_scrot

Surrounding areas has a linear feature hence there is a dashed border line.

pastk commented 10 months ago

@vng did 6c199705a6a12b7e8e0f034f8e21736367f11b03 fix it?

dvdmrtnz commented 10 months ago

I think this has been fixed. Tagging in the places shown in the original post has changed since then, but checking other highway=pedestrian multipolygons tagged without area=yes they seem to be rendering correctly in Organic Maps version ⁦2023.12.18-26⁩:

https://omaps.app/8n_T5Jjh4N/Plaza_del_Juez_Elío om://8n_T5Jjh4N/Plaza_del_Juez_Elío https://www.openstreetmap.org/relation/1727158#map=19/42.81759/-1.65730

--

https://omaps.app/4n_Tz7g1Al/Paseo_Santxiki om://4n_Tz7g1Al/Paseo_Santxiki https://www.openstreetmap.org/relation/1364762#map=17/42.80023/-1.61372

pastk commented 10 months ago

Yes the generator now adds area=yes to multipolygon relations explicitly.

But why those areas don't have border lines then?

dvdmrtnz commented 10 months ago

But why those areas don't have border lines then?

I don’t know why, but I think they look better without an outline

dvdmrtnz commented 10 months ago