Turn problem for latest data snapshot (220506)

[AntonM030481]

Latest data snapshot (220506) has next turn problems:

1. (Debug) Running bicycle_route_test.cpp::SpainTenerifeAdejeVilaflor Avoid next roads: RoutingOptions: {} routing section for Spain_Canary Islands loaded in 0.317133 seconds Routing in mode: Joints Route build time: 1351 ms TID(1) ASSERT FAILED routing/turns_generator.cpp:1189 CHECK(turnCandidates.front().m_segment == firstOutgoingSeg) routing_integration_tests: /home/planet/omapsapp-private/routing/turns_generator.cpp:1189: void routing::turns::GetTurnDirection(const routing::turns::IRoutingResult&, size_t, const routing::NumMwmIds&, const routing::RoutingSettings&, routing::turns::TurnItem&): Assertion `false' failed. Aborted (core dumped)

2. (Release) or if remove assert above. bicycle_turn_test.cpp::RussiaMoscowSevTushinoParkBicycleWayTurnTest pedestrian_route_test.cpp::BelarusMinskRenaissanceHotelUndergroundCross turn_test.cpp::Russia_Moscow_BolshoyKislovskiyPerBolshayaNikitinskayaUl_TurnTest turn_test.cpp::Netherlands_Barneveld_TurnTest

3. (Warnings) "nodes.candidates are not expected to have same m_angle."

[AntonM030481]

@vng how to get data snapshot (220506)?

[vng]

• First, please check assert with current 220415 data.

UPD: This will not work in cross mwm routing, because the branch that can read new cross-mwm index is still under my development.

• If not reproduced, download files manually from https://cdn.organicmaps.app/maps/220506 and put them into your current 220415 folder

[AntonM030481]

Using new Belarus_Minsk Region.mwm:

Running pedestrian_route_test.cpp::BelarusMinskRenaissanceHotelUndergroundCross
Loaded countries list for version: 220415
Settings path: ./data/settings.ini
Avoid next roads: RoutingOptions: {}
TID(1) ASSERT FAILED
indexer/features_vector.cpp:16
CHECK(m_metaDeserializer) 
Assertion failed: (false), function FeaturesVector, file features_vector.cpp, line 16.

[vng]

Yes, try to reproduce and fix assert on 220415 data for Spain (28.11984, -16.72592) -> (28.15865, -16.63704)

[AntonM030481]

For 220415 it is fine.

[vng]

Ok, please, take this branch https://github.com/organicmaps/organicmaps/pull/2539 and check 220506

[AntonM030481]

I was able to reproduce issue in SpainTenerifeAdejeVilaflor. In fact this is start of the route from (28.11984, -16.72592) to (28.1197394, -16.726004). If shift start point just a bit (visually the same, e.g. (28.1198395, -16.7259453)) - no problem (no turnCandidates). But for this particular point - somehow one turnCandidate appears in RoutingEngineResult::GetPossibleTurns() and check is failed (angle of this candidate == 0, and this does not match expected 90 (right turn)). This is the turn from grey to magenta, so I suppose angle should be 90, not 0. But maybe we can skip 1st turn determination after going from grey.

[AntonM030481]

BelarusMinskRenaissanceHotelUndergroundCross Here I can see following picture. 1 TurnRight looks good here. Looks like the test is irrelevant. Maybe route is different now from before. My suggestion is to add distance check in all tests before any turns checks.

I didn't change anything (by intention) for pedestrians yet. And didn't test it, just checked the number of failed tests before and after my changes. Looks like a lot of tests need to be updated.

[AntonM030481]

• bicycle_turn_test.cpp::RussiaMoscowSevTushinoParkBicycleWayTurnTest
• turn_test.cpp::Russia_Moscow_BolshoyKislovskiyPerBolshayaNikitinskayaUl_TurnTest
• turn_test.cpp::Netherlands_Barneveld_TurnTest

are expected to fail. https://github.com/organicmaps/organicmaps/pull/2508#issue-1224134588

[vng]

Ok, thanks!