Open rtsisyk opened 3 years ago
Automatic for map & navigation
Me personally don't see a point in this option. It adds flexibility, of course, but I don't know the navigation app that has such logic - usually the "dark" theme means dark theme in all modes.
Besides, as I already mentioned in #366 , changing theme to light when returning to map mode is very strange - dark theme is for navigating at night, and switching to light theme will just blind you.
Use system theme <!-- must handle theme changing events
Strange option for navigation app IMHO, but some other apps (e.g. Yandex Maps) are using it, so may be it's worth to be added
Let's not create another OSMand and make it simpler. For now, just change the behavior for auto and make it taking the system theme, as all users expect.
And move this setting out of the Navigation block.
just change the behavior for auto and make it taking the system theme, as all users expect.
I doubt that users expect that Auto
will inherit system theme - there's usually a separate setting for it
I doubt that users expect that
Auto
will inherit system theme - there's usually a separate setting for it
Personally, I would expect it, but make it clear, rename it to »Use system theme« and use it for maps and navigation.
I'll explain my point more thoroughly:
Considering terms 2 and 3, it's not very nice to change Auto
mode to inherit OS settings 'cause in some cases it'll still always be dark or light theme - separate setting like Inherit OS theme
would be better
Let's not create another OSMand and make it simpler. For now, just change the behavior for auto and make it taking the system theme, as all users expect.
No, It doesn't work and we receive negative feedback regarding broken night mode.
we receive negative feedback regarding broken night mode.
Really? Where? I see people, like me, wondering why »Auto« does not work for the whole UI, not just while navigating. I just searched the issues and App store comments and can't find anyone complaining that there are too few customizations of the night mode or complain about it covers the whole UI.
@rtsisyk I like the idea with renaming it to "Use system theme".
So let's:
The current behavior (where navigation switches to night mode) is how G Maps works. It is how OsmAnd works by default. It is how the Uber Driver app works. I'm sure other map apps work the same way.
We need to not violate the principle of least astonishment while also providing a minimal set of options that will work well for most people.
The settings we need (IMO):
The auto day/night mode is a navigation only option that turns navigation into day/night mode based on sunrise and sunset. In this mode, the system drops back to the app theme after navigation is over.
While I understand that we did receive a complaint about this behavior, most other navigation apps have this behavior, so I think we should provide it in order to provide what most users expect.
@TimMagee does "App Theme" affects the map theme too? I thought about two options, but wanted to keep it simple.
The current behavior (where navigation switches to night mode) is how G Maps works. It is how OsmAnd works by default. It is how the Uber Driver app works. I'm sure other map apps work the same way.
Just tried the following apps:
Light
/ Dark
/ As system
options. No Auto
at all;Auto
/ Day
/ Night
.
So you can't set G Maps to constantly work with the same theme in Auto
mode;Day
/ Night
/ Auto
options. In Auto
mode, theme stays constant, i.e. doesn't change to light when cancelling the route;On
/ Off
/ Auto
/ System theme
. In Auto
mode, theme stays constant, i.e. doesn't change to light when cancelling the route;On
/ Off
/ Auto
/ System theme
. In Auto
mode, theme stays constant, i.e. doesn't change to light when cancelling the route;Browse map
and Driving
. For day/night mode there's a Sunrise
/ Sunset
/ Day/Night
/ Light sensor
. The least is very strange option, and settings scheme is pretty clumsy, but you can set Day/Night
for browsing map and navigation.Haven't tried the Uber Drive (50 000 000+) 'cause it requires an account, but in their guide we can see that there's a Night mode
setting with Auto
\ On
\ Off
options. May be theme is constant for map and navigation too.
So I wouldn't say that the majority of the apps doesn't allow to at least set them to use constant theme in Auto
mode. IMHO Yandex Maps scheme is the best.
My initial error when creating FR was that I didn't realize that Night Mode setting was in the Navigation section, although I still can't understand why it's good when your eyes are blinded with light theme at night.
Considering previous comments, I would vote for leaving the setting as it is now 'cause in the other case it'll be clumsy schemes like Google or even OsmAnd with tons of options made just to satisfy everyone
@rtsisyk In my plan, app theme definitely affects the map theme as well. It changes the menus and the maps to dark or light mode.
In the navigation settings, there is a setting that allows the user to make the app go dark during navigation at night because I think many users find that to be a good default (it is similar to how Osmand, and Google do it).
@PetbkA good research! Thanks!
it'll be clumsy schemes like Google or even OsmAnd with tons of options made just to satisfy everyone
I agree with you that we should make things simple. However, our current Dark theme is not really convenient for anything else except car navigation. See https://github.com/organicmaps/organicmaps/issues/688
The updated proposal is to have separate settings:
Map Theme:
Navigation Theme:
Map Theme defaults can be synchronized with Navigation Theme defaults as soon as we fix #688.
@biodranik @vng @keksikex @ooprizrakoo any thoughts?
There is also a popular feature request to have a dark mode UI with light mode map colors (maybe a bit less bright than normal).
So I think it can make sense to split dark app theme vs dark map style.
So I think it can make sense to split dark app theme vs dark map style.
👍 , we need a separate setting for app and map with Dark, Light, System and Auto options. Thus there won't be separate setting for map view and navigation, although I can't imagine who needs such strange splitting
@PetbkA While I won't go to my grave on this (I may switch back to OsmAnd but who cares, settings are built for the majority not for me), I only want the map in dark mode while I am navigating. I find the map dark mode annoying to look at and I never use it, unless I am navigating. When I am in navigation mode, I am not trying to browse the map. Instead I am looking at the road and my next turn and I don't want to be blinded by the normal mode.
In short, I need just "such a strange splitting".
What I don't understand is why someone would want dark menus but a light map. I mean, if the menus are bright, you don't get the battery or eye savings of night mode unless the map is also dark.
I feel that dark mode should cover the entire app (menus and map) but we should allow users to selectively enable it only during navigation because some users really hate darkmode unless they are driving at night and want the car to be as dark as possible.
I assume that some users want to have a "light" map because it's simply easier to read than the current implementation of a dark map. E.g. if we seriously improve the map readability, then users won't need to have a dark interface + the "light" map.
But I also see that we should take into account all possible use-cases:
By properly implementing all these 6 scenarios we'll get the most comfortable to use product.
@TimMagee , I guess I finally understood your point.
Will my proposition be fine with settings not for map+navigation and app, but for map+app and navigation:
Theoretically this will be fine at least for both of us.
The scheme you offered in your first post would definitely be NOK for me 'cause it excludes Auto
mode for the app, and I don't want to switch it manually 'cause System
option will be equal to Dark
in my case
I have another proposition based on @TimMagee's first one. While I think the last one from @PetbkA is good and more flexible, the simplest settings IMO would be something like this:
Dark
Light
(Default on OS's that don't have a system theme)System
(Default if available)Auto Day/Night
@n-peugnet , initially my vision of the best implementation was as one setting for map+app+navigation.
It turned out that there's different views that are opposite to it. The implementation to satisfy maximum of users is with two settings.
So when we're coming to two settings, I would prefer to give maximum flexibility. In your implementation I can't enable Auto mode for the app+map+navigation, so I'm standing for my last proposition where I can set app+map+nav to switch automatically while somebody can leave nav with dark theme but set app+map to some other option
In your implementation I can't enable Auto mode for the app+map+navigation
@PetbkA , ah sorry, the theme setting was meant for (App + Map + Navigation), I just edited. So I agree that there are less possible combination with my solution than with yours but this one was meant to be possible.
The whole point of my idea is to limit the numbers of possibilities, it is opinionated but also simpler IMO. Indeed, it seems that the only reason why somebody would want a different theme throughout the app would be when using the navigation at night, where a dark theme is more appropriate. In every other situation, why would the navigation theme differ from the rest of the app's one?
The only options that @n-peugnet is leaving out are the options for 'dark', 'light', and 'system' themes in navigation being set separately from the app/map theme.
If somebody wants navigation to always be dark and never light, I would be surprised if they want the app to auto switch between day/night mode when not in navigation.
In essence, I don't see a reason to have a separate setting for navigation theme (except to force day/night mode even when app theme is something else).
If a user wants navigation to always be dark (even during the day) then I think it's reasonable to assume that almost all such users will also want the rest of the app dark.
@TimMagee
If a user wants navigation to always be dark (even during the day) then I think it's reasonable to assume that almost all such users will also want the rest of the app dark
But you don't want it, do you? You wrote:
I find the map dark mode annoying to look at and I never use it, unless I am navigating
Meanwhile I want the whole app (or app+map+nav) to switch from Dark to Light theme automatically (and this is not what System
option will give, as I already wrote). And considering your comments, we just can't stay with one setting and will have to split it to app+map and nav
I am sorry to be pushy but my solution would accommodate both of these configurations:
Light
and keeping the checkbox checkedAuto Day/Night
and the checkbox will not have any effectSorry, @PetbkA, I should have clarified, I only use Dark Mode when both of the following conditions are true:
So @n-peugent's suggestion works perfectly for me.
And, if I understand correctly, you always want auto day/night mode (even when not navigating). Once again, this suggestion allows for this.
Using with Apple Carplay the map does display only in dark / night-mode. Regardless my settings. The settings work well in native mode only - but no influence on the carplay behaviour. Dark theme is not usable during daylight in carplay mode. No chance to recognize any roads.
Using with Apple Carplay the map does display only in dark / night-mode. Regardless my settings.
Night mode is set by the car, depending on the light sensor or the headlights on or something else. Settings in the app are ignored. So I would like the "auto" mode in the application to not be overwritten by the mode from the car.
Glad to see this being worked on. I use OM in my cars android head unit. At night beings set in auto mode, the screen totally blinds me.
This issue is more complex because CarPlay users also expect that these modes should work.
BTW its possible to have a dark UI with a light map style now via a following "hack":
BTW its possible to have a dark UI with a light map style now via a following "hack":
- enable the night mode is OM settings
- go back to the map screen and to the search
- enter "?light" in the search field
- go back to the map, enjoy! :)
Thats funny and nice, thanks. But it do not work great. It resets sometimes when reopening the app an the overlays (all POIs) are semi transparent:
Btw. I would love to have this combination.
text in current night mode is not readable idk how this went under the radar
I don't know if it has already been reported, but the automatic mode does not work when we are in the middle of a journey. For example, if it gets dark, OM does not switch to night mode, we have to exit the application and, when we enter it again, then it will have chosen it.
BTW, I also prefer to see the maps in the light theme even if we are in night mode.
When will the system default theme be added to the app? @biodranik @rtsisyk
text in current night mode is not readable idk how this went under the radar
In the latest release of Organic Maps on iOS Version: 2022.12.18-9 , the issue that I had earlier was fixed , but just on the main page , actually it’s everywhere .
@Akczht thanks for checking it, it's actually about #4009 and #4035, please let's continue there.
Is it possible to switch to dark mode when I'm in a tunnel and switch back when I'm out?
It depends on your car's sensors. CarPlay should work.
I dont speak from CarPlay. I mean the App itself
In theory that may be possible, because the map already has the tunnel data in it. Can you please create a separate issue for that?
The current behavior (where navigation switches to night mode) is how G Maps works.
Apple Maps shows a dark map when system dark mode is active, so maybe using that as default makes most sense on iOS.
It is not a big problem to switch to dark mode as Apple does. The issue is that our current dark map style was not designed for daylight use. It was designed to be used at night, in the car. So people who try to use it during the day won't see much on the map due to a low contrast.
On my iPhone the map is constantly on dark mode (or night mode?) in CarPlay. Regardless if iOS is set to dark or light mode or if night mode in the app is deactivated.
CarPlay is unusable at day as the map is way to dark. Any way to fix this?
@FabulousSoldier yes, check your CarPlay settings (NOT Organic Maps settings) when the device is connected, and select "auto" instead of "always dark".
@FabulousSoldier yes, check your CarPlay settings (NOT Organic Maps settings) when the device is connected, and select "auto" instead of "always dark".
Thank you that worked!
My only issue is that dark mode makes the map dark too. I wish I could do it just for the UI
Automatic dark mode in tunnel, like Apple CarPlay does: #5828
I just wanted to point out that “auto” Night Mode currently only works for navigating a car route, not for pedestrians and cyclists.
I’m commuting and travelling by bicycle and therefore use navigation mode with bicycle routes, not car routes.
Please keep in mind that many people travel by foot or bike after dark and therefore also need a navigation mode that works well with these forms of transport in these circumstances.
Especially during rainy nights riding in traffic, a light navigation view is basically unusable due to glare.
It should be easy to fix. There's likely an if (car routing)
check somewhere in the code that can be removed.
@FabulousSoldier yes, check your CarPlay settings (NOT Organic Maps settings) when the device is connected, and select "auto" instead of "always dark".
Unfortunately this is an imperfect workaround and not a solution. Users shouldn't have to change the look of the entire CarPlay UI in order to get Organic Maps to display as desired. Neither Apple Maps nor Google Maps show a dark map while CarPlay is in dark mode, only Organic Maps does:
Apple also seems to expect that people want light maps with dark mode, since once you select CarPlay dark mode, another entire option appears to "Always Show Dark Maps", implying light maps should be the default otherwise:
Our current day/night mode settings are misleading:
Users expect, that "Auto" will change the map theme also. The dark theme for maps is opinionated. Some people, including me, just doesn't like maps in the dark mode. However, the dark mode is really required during navigation in order not to dazzle the driver.
I propose to add more options:2023-12-29 updated after discussions.
Implement 3 options for Android, iOS, CarPlay and Android Auto:
Upvote & Fund