search

organicmaps / organicmaps

🍃 Organic Maps is a free Android & iOS offline maps app for travelers, tourists, hikers, and cyclists. It uses crowd-sourced OpenStreetMap data and is developed with love by MapsWithMe (MapsMe) founders and our community. No ads, no tracking, no data collection, no crapware. Please donate to support the development!
https://organicmaps.app
Apache License 2.0
8.7k stars 849 forks source link

[iOS] Non-Business Hours button works after midnight #7820

Closed RDOP0808 closed 1 week ago

RDOP0808 commented 1 month ago

Fixes #3036 Changed verifications to allow the non-business hours button to work after midnight.

RDOP0808 commented 1 month ago

Hello :) I believe the reason it wasn't passing through the Mac tests, was because of the Mac tests themselves and not because of my code, and I think you have already fixed it with since it was an issue

Jean-BaptisteC commented 1 month ago

Thanks for your contribution Can you rebase your branch and remove merge branch commits?

RDOP0808 commented 4 weeks ago

All Done :)) Sorry for the trouble and thank you :)

matheusgomesms commented 2 weeks ago

Is it good to merge @biodranik? Would love to see this already in this May version! :)

biodranik commented 2 weeks ago

Did someone test it on iOS and Android? CC @Jean-BaptisteC @kirylkaveryn

biodranik commented 1 week ago

@RDOP0808 congrats and welcome to the club! And sorry for the delay, we're too ~busy~ lazy sometimes ;-)