organicmaps / organicmaps

🍃 Organic Maps is a free Android & iOS offline maps app for travelers, tourists, hikers, and cyclists. It uses crowd-sourced OpenStreetMap data and is developed with love by MapsWithMe (MapsMe) founders and our community. No ads, no tracking, no data collection, no crapware. Please donate to support the development!
https://organicmaps.app
Apache License 2.0
8.58k stars 837 forks source link

Render shared paths with an underline, change cycleways color #7925

Closed pastk closed 1 week ago

pastk commented 2 weeks ago

Shared paths: add a cycling underline.

Depends on #7878

pastk commented 2 weeks ago

shared and dedicated image

z13 dedicated image

z17 shared unpaved image

Note that we might have a distinct color for paved vs unpaved dedicated cycleways too - similar to footways vs paths.

pastk commented 2 weeks ago

The new color is much more contrast against all backgrounds compared to the current violet. And hopefully is distinct enough from the rivers :) Dark green could be another option.

(table source) image

pastk commented 2 weeks ago
pastk commented 2 weeks ago

shared-urban-z13

shared-urban-z16

shared-od-z12

pastk commented 5 days ago

Another comparison with the previous color: cycleways-zurich-z13

map-per commented 5 days ago

Tested the PR with the new map data from #8009: Sometimes the blue line is drawn on top of the white line (e.g. https://www.openstreetmap.org/way/1158116910). Looks like it has something to do with segregated.

Edit: Looks like the bug occurs for all highway=path with segregated=yes

pastk commented 5 days ago

Tested the PR with the new map data from #8009: Sometimes the blue line is drawn on top of the white line (e.g. https://www.openstreetmap.org/way/1158116910). Looks like it has something to do with segregated.

Yeap its as intended:

It'd be better to render "segregated cycleways + footways" somehow different, e.g. a solid blue line along white dashes, but we don't have this capability ATM, see #7952

biodranik commented 5 days ago

It's too colorful for the main style, let's move these changes to the outdoor style.

map-per commented 5 days ago

Distinguishing paths for cyclists and not for cyclists in the main style is good. Especially for cycling in cities, as the the outdoor style is not designed for dense areas.

But especially at zoom 13 dedicated cycleways and segregated cycleways + footways do are very prominent.

I would either

or

biodranik commented 5 days ago

Please don't turn the clean main style into a second outdoor style but for cyclists. We all agree that creating a separate cyclist-centric style is the right option.

map-per commented 3 days ago

I didn't fully figure out what you changed for cycleways, but it looks good now. The blue lines are not too prominent any more. 👍

A few days ago now
signal-2024-04-30-102450_002 signal-2024-04-30-102450_003

(Location on OSM: https://www.openstreetmap.org/node/1681356475#map=15/48.1098/11.5378)

pastk commented 3 days ago

@map-per your "now" screenshot looks strange - the most of cycleways are just gone there :/ I guess it has a different map data version, e.g. from a previous release as most of those cycleways seem to be highway=path segregated=yes and were not displayed at low zooms

In the current beta it should be like (z14): image

Likely we'll reduce cycleways opacity a little on z13-14 before the release.

pastk commented 3 days ago

z14 from the last release for comparison (paths are not displayed on z13)

Screenshot_20240430-133826_.jpg

pastk commented 3 days ago

Stats:

So overall number of cycleways visible on z13-14 will significantly reduce, but in some regions like Munchen it could look vice versa.

biodranik commented 2 days ago

Display them prominently in Outdoors, and leave not prominent at all in the main style?

map-per commented 1 day ago

your "now" screenshot looks strange - the most of cycleways are just gone there :/ I guess it has a different map data version, e.g. from a previous release as most of those cycleways seem to be highway=path segregated=yes and were not displayed at low zooms

Oh, yes, that was the old map data from March. I overlooked that the new map data isn't merged into master yet.