search

organicmaps / organicmaps

🍃 Organic Maps is a free Android & iOS offline maps app for travelers, tourists, hikers, and cyclists. It uses crowd-sourced OpenStreetMap data and is developed with love by MapsWithMe (MapsMe) founders and our community. No ads, no tracking, no data collection, no crapware. Please donate to support the development!
https://organicmaps.app
Apache License 2.0
8.58k stars 837 forks source link

qt: Add route marking buttons to place pages #7931

Closed Ferenc- closed 2 weeks ago

Ferenc- commented 2 weeks ago

cc: @tristanvigar

Ferenc- commented 2 weeks ago

cc: @Bugsbane

biodranik commented 2 weeks ago

@Ferenc- thanks! The bottom buttons should be in a separate container that is not related to the left list of labels:

image
Ferenc- commented 2 weeks ago

@Ferenc- thanks! The bottom buttons should be in a separate container that is not related to the left list of labels

That behaviour is independent from this PR, so I have opened a separate PR for that https://github.com/organicmaps/organicmaps/pull/7940

biodranik commented 2 weeks ago

Bottom buttons in this pr should not increase spacing on the left column.

Ferenc- commented 2 weeks ago

Bottom buttons in this pr should not increase spacing on the left column.

I believe after the rebase, that is not happening anymore. Please check.

Bugsbane commented 2 weeks ago

Nice addition to see! I'm curious, does it's width fit a mobile device screen (eg 720px)? I ask as I'm mainly interested in eventually using Organic Maps on mobile Linux devices (eg Pine Phone Pro).

biodranik commented 2 weeks ago

Test and tell us :)

Ferenc- commented 2 weeks ago

does it's width fit a mobile device screen (eg 720px)

It depends on a couple of things. I am thinking about a way to keep the size within bounds.

pastk commented 2 weeks ago

@Ferenc- when I close the PP via Esc or a window close button (not the "Close" button inside the PP) it sets a route starting point (as if I've pressed the "Route from" explicitly).

biodranik commented 2 weeks ago

Good catch! @Ferenc- can you please fix that?

Ferenc- commented 2 weeks ago

Good catch! @Ferenc- can you please fix that?

https://github.com/organicmaps/organicmaps/pull/7956