search

organicmaps / organicmaps

🍃 Organic Maps is a free Android & iOS offline maps app for travelers, tourists, hikers, and cyclists. It uses crowd-sourced OpenStreetMap data and is developed with love by MapsWithMe (MapsMe) founders and our community. No ads, no tracking, no data collection, no crapware. Please donate to support the development!
https://organicmaps.app
Apache License 2.0
8.58k stars 837 forks source link

use git-auto-commit to regenerate styles and strings automatically #7948

Open RedAuburn opened 2 weeks ago

RedAuburn commented 2 weeks ago

https://github.com/marketplace/actions/git-auto-commit

we could use this to automatically regenerate styles and strings when a PR is submitted

dvdmrtnz commented 2 weeks ago
pastk commented 2 weeks ago

What value will it bring? Regenerate for cases when a developer forgot to include those commits? For such cases it'd be better to remind/warn developers (e.g. by failing tests) instead of trying to auto-fix it IMHO.

pastk commented 2 weeks ago

For that it'll have to remove the currently present (in the PR) regenerate commits and add new ones...

RedAuburn commented 2 weeks ago

What value will it bring? Regenerate for cases when a developer forgot to include those commits?

it would mean that developers wouldn't need to add those commits in the first place, as it would be done automatically. this would also mean regenerating the commits for a merge would just be a case of re-running the action, instead of messaging, then waiting for the dev to push, then merging. it sidesteps the little dance that's needed to merge things in order

pastk commented 2 weeks ago

it would mean that developers wouldn't need to add those commits in the first place, as it would be done automatically.

That means a developer must not forget to remove those the commits before the push..

this would also mean regenerating the commits for a merge would just be a case of re-running the action, instead of messaging, then waiting for the dev to push, then merging. it sidesteps the little dance that's needed to merge things in order

That would be nice indeed! So this action would be capable of removing the conflicting commits first?

RedAuburn commented 2 weeks ago

That means a developer must not forget to remove those the commits before the push..

not if they never added them 😉

That would be nice indeed! So this action would be capable of removing the conflicting commits first?

i believe so, it might be a little bit of scripting to make work though

pastk commented 2 weeks ago

That means a developer must not forget to remove those the commits before the push..

not if they never added them 😉

That means the PR was not tested by the developer - not a type of behavior we'd like to promote 😂

RedAuburn commented 2 weeks ago

That means the PR was not tested by the developer - not a type of behavior we'd like to promote 😂

good point.. still, the second use-case is still useful 😅

pastk commented 2 weeks ago

That would be nice indeed! So this action would be capable of removing the conflicting commits first?

i believe so, it might be a little bit of scripting to make work though

Then the action should