search

organicmaps / organicmaps

🍃 Organic Maps is a free Android & iOS offline maps app for travelers, tourists, hikers, and cyclists. It uses crowd-sourced OpenStreetMap data and is developed with love by MapsWithMe (MapsMe) founders and our community. No ads, no tracking, no data collection, no crapware. Please donate to support the development!
https://organicmaps.app
Apache License 2.0
8.58k stars 837 forks source link

Supermarket mapped as site relation not showed in the map #7949

Open muralito opened 2 weeks ago

muralito commented 2 weeks ago

Describe the issue A supermarket mapped as relation is not showed in the map, neither in the map view, nor searching for it with categories. https://www.openstreetmap.org/relation/17294450

If you search for name, the blue dots appears over the parking and the parking entrance.

Steps to reproduce Search in the map for the relation https://www.openstreetmap.org/relation/17294450

Expected behaviour Supermarket is shown as when mapped as node or way.

System information:

Additional context Maybe there is an error in the map data, the supermarket is mapped as a relation because is a supermarket in the low level of the building with entrances in both streets.

matkoniecz commented 2 weeks ago

type=site is not a good method of mapping unless it absolutely cannot be avoided

why not map it in a normal way? Note that with current method of mapping it will be missing for nearly any data consumer - and also will remain highly confusing for other mappers

supermarket in the low level of the building with entrances in both streets.

it can be mapped as area with level tag and with entrance mapped as entrance=, right? Maybe map supermarket and indoor corridors?

muralito commented 1 week ago

type=site is not a good method of mapping unless it absolutely cannot be avoided

why not map it in a normal way? Note that with current method of mapping it will be missing for nearly any data consumer - and also will remain highly confusing for other mappers

supermarket in the low level of the building with entrances in both streets.

it can be mapped as area with level tag and with entrance mapped as entrance=, right? Maybe map supermarket and indoor corridors?

Mapping as a site relation was a test to see how some applications handle/support it. Mapping as two nodes, closer to the entrances, is not real. Mapping as a single node, which could be appropriate if the supermarket has only one entrance, in this case does not guide the user to the closer entrance.

It could be mapped as a way, but it is impossible to know the exact perimeter. because it has three buildings on top, and it does not completely occupy level 0. On level 0 there are also entrances to the buildings, garages, and other services.

Therefore, I took the option of drawing it "diffuse", with two nodes and not with an area, just that in this case both nodes doesn't have the data in it, but are part of the site relation.

matkoniecz commented 1 week ago

Mapping as two nodes, closer to the entrances, is not real.

that would definitely be a bad idea

Mapping as a single node, which could be appropriate if the supermarket has only one entrance, in this case does not guide the user to the closer entrance.

mapping shop as node is fine - and continues to be fine if shop has one entrance, two or 22.

you can map shop as node and map highway=corridor or other way of mapping indoor ways.

Even mapping approximate area would be better than site relation.

BTW, changing title may be a good idea - multipolygon relations are almost certainly supported