search

organicmaps / organicmaps

🍃 Organic Maps is a free Android & iOS offline maps app for travelers, tourists, hikers, and cyclists. It uses crowd-sourced OpenStreetMap data and is developed with love by MapsWithMe (MapsMe) founders and our community. No ads, no tracking, no data collection, no crapware. Please donate to support the development!
https://organicmaps.app
Apache License 2.0
8.58k stars 837 forks source link

[generator][indexer] include collection_times in map data (no display/edit yet) #7950

Open RedAuburn opened 2 weeks ago

RedAuburn commented 2 weeks ago

working in parts to make it easier to review & work on. This PR only includes it into the map data, no user-facing display yet.

part of https://github.com/organicmaps/organicmaps/issues/2431

RedAuburn commented 1 week ago

Further work kind of blocked by https://github.com/organicmaps/organicmaps/issues/7974, as parsing should be done through whatever lib we use.

Maybe we can just display the collection_times as text for now? It'd still be useful in that form

Misalf-git commented 1 week ago

It'd still be useful in that form

Indeed

RedAuburn commented 6 days ago

Will it be displayed properly in the UI? Does our UI support displaying single-time values, not ranges?

Eventually yes, but as mentioned I think it's kind of blocked by #7974. The current proposal is to just display as the raw values eg. Mo-Fr 09:00; Sa 12:00. As collection time strings are usually relatively simple, and it's really useful information.

And what about the editor? It should have a different UI, right?

only slightly, instead of selecting a to-from time, it would just be a single point.

Which OSM objects have this feature?

the big one is amenity=post_box, 45% (169,103 post boxes) have it tagged. it's particularly well tagged in the UK. also it's used for recycling etc.