organicmaps / organicmaps

🍃 Organic Maps is a free Android & iOS offline maps app for travelers, tourists, hikers, and cyclists. It uses crowd-sourced OpenStreetMap data and is developed with love by MapsWithMe (MapsMe) founders and our community. No ads, no tracking, no data collection, no crapware. Please donate to support the development!
https://organicmaps.app
Apache License 2.0
9.97k stars 955 forks source link

Wrong area edited when two areas share the same nodes #9405

Open matheusgomesms opened 1 month ago

matheusgomesms commented 1 month ago

Just happened to me: went to update a POI on OM (which I later saw on OSM that it is a building, not a node), and instead of updating it, the information went to a building:part instead of the original building. Detailed case:

1 - POI is mapped as a building=* 2 - this building has also building:part inside 3 - I added more details in OM (opening_hours, addresses) 4 - this new info (and some old info, but not all of them!) was transferred to a building:part (and not to the building itself)

Please check it out: building:part (v2 and v3): https://www.openstreetmap.org/way/569389871/history the building/POI itself: https://www.openstreetmap.org/way/569389874/history

Chiming in @map-per, since their recent work on Editor.

map-per commented 1 month ago

Interesting. OM doesn't store the OSM ID of objects. When uploading the coordinates of the point(s) are used to find the right Object. Looks like OM doesn't handle cases where two areas have the same nodes correctly.

The OM map data looks good:
Bildschirmfoto vom 2024-10-01 07-47-32 Bildschirmfoto vom 2024-10-01 07-52-53