search

organicmaps / organicmaps

🍃 Organic Maps is a free Android & iOS offline maps app for travelers, tourists, hikers, and cyclists. It uses crowd-sourced OpenStreetMap data and is developed with love by MapsWithMe (MapsMe) founders and our community. No ads, no tracking, no data collection, no crapware. Please donate to support the development!
https://organicmaps.app
Apache License 2.0
9.98k stars 957 forks source link

Color of yellow road shields in dark mode #9676

Open sostock opened 5 days ago

sostock commented 5 days ago

In dark mode, yellow road shields become green. I think the color of the road shields in the app should be the same as the color of the actual shields, i.e., yellow shields should stay yellow. The green color might lead to confusion since there are shields that are actually green.

See below: B 3 and B 33 change color.

Light Dark
Screenshot in light mode Screenshot in dark mode

If the current behavior is intentional (because yellow shields might be too bright for dark mode), the shields could maybe become yellow text on black background, so that the yellow color is still present? It would be like the black-on-white shields, which become white-on-black (L 91, L 98, L 99 in the screenshots).

Also, the black text on green background is hard to read, which makes me think that this is a mistake instead of intentional behavior.

System information:

pastk commented 4 days ago

Fix the RoadShieldOrangeBackground-color: #136C30; color in data/styles/default/dark/style.mapcss and run the generate_drules.sh script, see details in docs/STYLES.md.