search

orgapp / orgajs

parse org-mode content into AST
https://orga.js.org
MIT License
612 stars 63 forks source link

unist-builder and prismjs should be dependencies? #21

Open titaniumbones opened 5 years ago

titaniumbones commented 5 years ago

just trying out the package (working towards this issue for a vscode plugin: https://github.com/vscode-org-mode/vscode-org-mode/issues/133). Tests failed until I installed unist-builder and prismjs, so I'm assuming they need to be added to the dependencies list?

xiaoxinghu commented 5 years ago

@titaniumbones which package are you talking about? oast-to-hast is the only one who depend on unist-builder and prismjs, and they are in the dep list. orga itself doesn't have any dependency.

titaniumbones commented 5 years ago

When I tried to run the orgsjs test suite, most failed until I installed those two packages manually.

I will try to look at this more carefully though. I was just reporting the failure.

On Mar. 22, 2019 4:51 a.m., Xiaoxing Hu notifications@github.com wrote:

@titaniumboneshttps://github.com/titaniumbones which package are you talking about? oast-to-hast is the only one who depend on unist-builder and prismjs, and they are in the dep list. orga itself doesn't have any dependency.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/xiaoxinghu/orgajs/issues/21#issuecomment-475539419, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAWPNCADr9jeb04FmVj3AhCYwKwWi9b6ks5vZJl2gaJpZM4b78i9.

xiaoxinghu commented 4 years ago

I have updated the readme; please reference the Contribute part to make sure you are running the tests the right way. I think your failure is most likely due to using npm instead of yarn. I am using yarn because the workspace feature made the development of gatsby plugin easy (and possible). I'd like to switch back to npm when their equivalent of workspace feature is ready. (They said it's going to be included in the next major version.)