orgua / OneWireHub

OneWire slave device emulator
GNU General Public License v3.0
343 stars 86 forks source link

Remove firmware flashing and enable software side versions #24

Closed Giermann closed 7 years ago

orgua commented 7 years ago

looks good! just my two cents:

Giermann commented 7 years ago

My first attempt was also to put SW_VER and BOOTSTRAP_VER into the constructor, but then I found it easier to have those in normal registers.

Regarding device and chip type: those are flagged "factory fixed" in the datasheet. The device type has to be fixed to 2 to identify the device as BAE0910. Otherwise it will not show the /910/ subfolder in OWFS. If it identifies as type 3, there will be a /911/ subfolder with a different instruction set and different registers. This would require another BAE0911 implementation. The chip type doesn't seem to have any specific effect, only the comment: "type= 0x01 for the MC9S08SH8, 8 pin package soic8". So this might be a good place to have some fixed library version of OneWireHub there? I would keep it hard coded to identify client devices to be built with a specific OneWireHub library, copying the original "factory fixed" values and have the other two version numbers changable by client code.

orgua commented 7 years ago

sorry, i missed the comment after these values! documentation says it all - very good