orgua / OneWireHub

OneWire slave device emulator
GNU General Public License v3.0
343 stars 86 forks source link

DS2450 : Invalid argument in OWFS when reading voltages such as volt.A #70

Open FragJage opened 5 years ago

FragJage commented 5 years ago

Hello, I am using an arduino nano to emulate a DS2450. When OWFS read the DS2450, voltages values display "Error: Invalid argument", all other values are correctly readed. image I have read the readme.md, it's not a timing problem. I have rebuild owfs with debug informations, and i have understand the problem : To read a voltage value, OWFS send the convert command (0x3C code) and wait, with timeout, the slave to announce the end of the conversion, but the DS2450 emulation don't send this information.

I have add hub->sendBit(true); after hub->sendBit(false); on line 63 of DS2450.cpp and now OWF display all voltage values.

Do you think it's good ? Do you want a pull request ? Thanks.