orgzly-revived / orgzly-android-revived

Outliner for taking notes and managing to-do lists
https://www.orgzlyrevived.com
GNU General Public License v3.0
649 stars 41 forks source link

Support Obtainium #14

Closed edmundmiller closed 11 months ago

edmundmiller commented 1 year ago

https://github.com/ImranR98/Obtainium

If someone with permissions could cut a pre-release like I have in my fork, then we'd be able to point people to download it with Obtainium while #7 gets figured out.

https://github.com/orgzly-community/orgzly-android/issues/7

edmundmiller commented 1 year ago

This might be useful https://github.com/marketplace/actions/signed-release-apk-publisher https://github.com/marketplace/actions/build-android-app

edmundmiller commented 1 year ago

@amberin That worked! Might be able to get some CI setup for whenever it get's tagged it'll autocreate a release and sign it.

amberin commented 1 year ago

@amberin That worked! Might be able to get some CI setup for whenever it get's tagged it'll autocreate a release and sign it.

That would be ideal, because I assume that would make it easier to co-own the signing key.

I don't understand why Obtainium is picking up the old app name, but yes, apart from that it seems to work. (I suppose there must be some metadata file containing the name I couldn't find?)

amberin commented 1 year ago

I have suggested a solution in #16.

amberin commented 1 year ago

I have now published an official "prerelease" APK. I can add the app in Obtainium, but only via the repo URL. I wonder what it takes to make Obtainium discover the app/repo via name search? The original repo has no Github releases, but it is still discoverable... Not sure where I got that from -- the original repo does too have Github releases. So let's see once we have a proper release tagged as "latest", if the app becomes searchable then.

edmundmiller commented 1 year ago

Yeah I think the version regex is off with the prerelease... the real releases seemed to work.

amberin commented 1 year ago

I have now released v1.8.11 proper, but I still can't find us via search in Obtainium. :(

edmundmiller commented 1 year ago

Ah, I just added the repo URL! The new version looks like it updated properly, I think it was the beta part that threw it off.

edmundmiller commented 1 year ago

Okay, the new beta installed just fine! Not sure what changed, but I'm calling this done!

amberin commented 1 year ago

@Emiller88 That's great, but our app is still not searchable in Obtainium, as opposed to the original app. It can only be found by entering the exact repo URL. I don't think this is great, especially since the original app is fully searchable, I don't see why ours should be any different... :/

edmundmiller commented 1 year ago

Hmm that's really weird I see it too. Maybe the tags? There's an android tag? Probably should open an issue with obtainium.

kai11 commented 1 year ago

https://api.github.com/search/repositories?q=orgzly+revived

At the time of writing URL above returns 0 results.

https://api.github.com/search/repositories?q=fork:true+orgzly+revived

Returns 4 results, this repo is first.

Orgzly-revived is a fork for GitHub search engine.

kai11 commented 1 year ago

On my own repos I don't see any way to "unfork" repository. I think you should create duplcate for that. Fork is intended for upstream contribution.

More info: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/about-forks#forking-a-repository-versus-duplicating-a-repository

PS. I think it makes sense to create duplicate of this repo, not original one.

kai11 commented 1 year ago

For comparison:

https://api.github.com/search/repositories?q=syncthing+fork

Syncthing Fork by Catfriend1 is not fork at all (fork:false)

amberin commented 1 year ago

Nice findings, @kai11. We've said that the goal is to contribute our work to the original app, if it resumes development. But this of course does not require the "fork" status on our repo.

I'm worried that it seems hard to "unfork"... Setting up another repo would probably be quite some work, considering security settings, discussions, issues and PR history.

kai11 commented 1 year ago

@amberin It's not that bad. You can contact GitHub support - https://stackoverflow.com/a/16052845

amberin commented 1 year ago

@amberin It's not that bad. You can contact GitHub support - https://stackoverflow.com/a/16052845

Great - I'll email them.

amberin commented 1 year ago

I have opened a ticket via Github's virtual assistant to "extract" our fork.

amberin commented 11 months ago

The repo has been decoupled and is now no longer a fork. The app is now searchable in Obtainium.

I don't know if the difference between version tag and version name format will cause Obtainium to mis-identify versions, but let's handle any such problems separately. Closing this.