orgzly-revived / orgzly-android-revived

Outliner for taking notes and managing to-do lists
https://www.orgzlyrevived.com
GNU General Public License v3.0
677 stars 42 forks source link

Webdav encounters 403 authorization error after upgrade to 1.8.29 #403

Open Forge36 opened 2 weeks ago

Forge36 commented 2 weeks ago
Device: Pixel 8a
Android Version: 14
Orgzly Revived Version: 1.8.29
Sync repository type (directory/Dropbox/WebDAV/Git): WebDav

I've downgraded to 1.8.28 and disabled automatic updates in the interim.

Note: I upgraded to 1.8.30 and I'm still seeing the error.

amberin commented 2 weeks ago

Thanks for reporting. If you could provide a step-by-step on how to reproduce this error, that would be very valuable. Also, please provide as much technical info as possible about the WebDAV server.

amberin commented 2 weeks ago

@Forge36 I just built an APK with just the WebDAV library downgraded, if you could try it out, that would be fantastic. To install it, you'll need to download one of the artifacts on this page, unzip the APK, transfer it to your phone and open it. (Or, if you have adb, you can use "adb install \<apk filename>".)

Forge36 commented 2 weeks ago

That works!

I'm running

As it turns out that's also out of date (but doesn't report so), I'm manually updating my server, which will allow me to update the webDav server.

I'll update if I continue to need the package downgrade after updating my server.

Edit: updating to

Did not resolve this issue

For reproduction steps, what are you looking for?

amberin commented 2 weeks ago

For reproduction, just exactly what you are doing when the problem arises, and exactly what you are seeing. A screenshot is always good.

Obviously, something has changed in the library we depend on, so they could have a bug, and if so we should report it to them.

I'll downgrade the library for the next release, in any case.

Forge36 commented 2 weeks ago

Two workflows tested:

image

image

I can include full logs via logcat if you'd find those helpful. The only entry that appeared relevant was (adjacent logs not clearly related to sync)

[11-10 10:36:00.306 14307:14415 I/WM-WorkerWrapper] Worker result FAILURE for Work [ id=98c95830-ddf6-4a7e-93de-67704b6a1023, tags={ com.orgzly.android.sync.SyncWorker } ]

Forge36 commented 2 weeks ago

Looking at the dependency commits: https://github.com/thegrizzlylabs/sardine-android/compare/v0.8...v0.9#

Only two looked functional

https://github.com/thegrizzlylabs/sardine-android/commit/5d7883cef19b2753c6e508a2febb44084a7ea8c2

and

https://github.com/thegrizzlylabs/sardine-android/pull/58/commits/2365354c456712fdc89f313825bb170cc052dfa5

My URL does not contain spaces or percent encoding. Though I can't rule that out. The exists check is suspect combined with the other issue of some servers reporting 403 for non-existence.