search

orhanobut / hawk

✔️ Secure, simple key-value storage for Android
Apache License 2.0
3.98k stars 388 forks source link

Hawk isn't a 64-bit compliant library #233

Open caiodev opened 5 years ago

caiodev commented 5 years ago

According to these 2 links, those apps who support 32-bit devices only will no longer be accepted by Google play starting August, 1st:

https://android-developers.googleblog.com/2019/01/get-your-apps-ready-for-64-bit.html

https://developer.android.com/distribute/best-practices/develop/64-bit

And Hawk uses Conceal which is a Library that uses native code and if one analyzes an APK that uses Hawk, one will be able to see that the only obstacle to make one's app 64-bit compliant is the Conceal dependency that Hawk uses(Refer to this link and follow the steps: https://developer.android.com/distribute/best-practices/develop/64-bit). Do you have any plan on how to remove this dependency from Hawk and change it so it can be 64-bit compliant? I look forward to hearing from you soon. Thank you

halysongoncalves commented 5 years ago

Please, can we migrate to this version? Conceal 64 bits

GabriellCosta commented 4 years ago

Please, can we migrate to this version? Conceal 64 bits

I created a PR for that https://github.com/orhanobut/hawk/pull/238 : D

mkruglikov commented 4 years ago

Excluding conceal from hawk and adding newer version by myself helped me for now

    implementation('com.orhanobut:hawk:2.0.1') {
        exclude group: 'com.facebook.conceal', module: 'conceal'
    }
    implementation 'com.facebook.conceal:conceal:2.0.2'