- folder name option added for DiskLogAdapter.

orhanobut / logger

✔️ Simple, pretty and powerful logger for android

Apache License 2.0

13.78k stars 2.14k forks source link

- folder name option added for DiskLogAdapter. #224

Open ummarbhutta opened 5 years ago

ummarbhutta commented 5 years ago

max file size option added for DiskLogAdapter.
packages updated

Guiorgy commented 5 years ago

also, change buildToolsVersion = '27.0.3' to buildToolsVersion = '28.0.3' in logger/build.gradle (in the root folder)

ummarbhutta commented 5 years ago

@Guiorgy The buildToolsVersion is already 28.0.3

Guiorgy commented 5 years ago

@Guiorgy The buildToolsVersion is already 28.0.3

You replaced a global variable (rootProject.ext.buildToolsVersion) with a constant (28.0.3) in multiple files. I am just saying, that you should revert them back and change the variable value instead.

ummarbhutta commented 5 years ago

Hello @Guiorgy

Thanks for suggestions and I accepted your suggestions and committed.

nikitph commented 3 years ago

can someone please merge this. we need this for a project

lupaulus commented 2 years ago

I forked and updated the project : Forked Project