master - Githubissues

orhanobut / tracklytics

✔️ Annotation based tracking handler with aspect oriented programming

Apache License 2.0

429 stars 45 forks source link

master #48

Closed Kolyall closed 5 years ago

Kolyall commented 5 years ago

Fix of issue: https://github.com/orhanobut/tracklytics/issues/47

updated to gradle:3.3.0:
1. Changed buildToolsVersion to "28.0.3"
2. Replaced variant.javaCompile to if (variant.hasProperty('javaCompileProvider')) {// Android 3.3.0+ javaCompile = variant.javaCompileProvider.get() } else { javaCompile = variant.javaCompile }
3. Moved String[] args to doLast task (because args can't be init before assembleTask)
4. replaced compile to implementation
5. removed .idea files
6. Updated ReadMe file

furflez commented 5 years ago

@Kolyall your fork is working fine?

Kolyall commented 5 years ago

@furflez Yes

Kolyall commented 5 years ago

@furflez seems owner doesn't work with github any more

orhanobut commented 5 years ago

Thanks for updating the lib dependencies. 👍 Looks great. Let me see why Travis build failed.

orhanobut commented 5 years ago

I'll merge it and publish the artifacts, that'll fix Travis as well. Thanks for the contribution 🎉

andreas- commented 5 years ago

We checked out the PR, included the gradle plugin jar and aar locally. Build seems working fine but we can't get the aar working when referencing locally. Events are not tracked on our test setup

orhanobut commented 5 years ago

@andreas- I just published the artifacts of 2.1.0 version. Can you try with that version? It should be available now.