orhun / CoolModFiles

A web player that plays some cool MOD files randomly 🎶
https://CoolModFiles.com
GNU General Public License v3.0
131 stars 12 forks source link

feat: Add volume adjust to player #21

Closed Cthulhu2 closed 2 years ago

vercel[bot] commented 2 years ago

Someone is attempting to deploy a commit to a Personal Account owned by @orhun on Vercel.

@orhun first needs to authorize it.

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/orhun/cool-mod-files/Bd8rQSCNPwueG4H6GhYo8moajMub
✅ Preview: https://cool-mod-files-git-fork-cthulhu2-feature-2-volume-adjust-orhun.vercel.app

WKFO commented 2 years ago

Very nice! One suggestion though. Could we move the slider over to the left hand side like this? Just so it doesn't get confusing with two horizontal sliders. (PS. the icon isn't a necessity for now) id :

Cthulhu2 commented 2 years ago

Could we move the slider over to the left hand side like this? Just so it doesn't get confusing with two horizontal sliders. (PS. the icon isn't a necessity for now):

@WKFO, 2347203, moved with using div and flex containers, without icon. Unfortunately, I don't now how to SVG.

orhun commented 2 years ago

rec_20211202T155022

I'm having this issue while selecting a previous/next track. Player UI gets smaller and bigger based on the text I think (?). Can you look into this? @Cthulhu2

Cthulhu2 commented 2 years ago

Player UI gets smaller and bigger based on the text I think (?)

@orhun, I can't force align/justify items in .metadata. So fix 7840fb0 with using columns style and width.

orhun commented 2 years ago

I pushed 07cf696 for hiding the volume slider when it's not hovered. Just to make the player UI look less crowded...