orhun / CoolModFiles

A web player that plays some cool MOD files randomly 🎶
https://CoolModFiles.com
GNU General Public License v3.0
131 stars 12 forks source link

Unable to skip ahead in track #52

Closed WKFO closed 1 year ago

WKFO commented 1 year ago

I'm back with probably what's another edge-case issue.

Playing track id 138328, you can not skip ahead further into the track. Attempting to do so ends the track and loads a new one - unless one has repeat turned on, in which case it will just not skip ahead and do a weird echo (double playing every note) for the duration of a single pattern before fixing itself. I don't know if this has something to do with libopenmpt handling .xm files, but I don't remember all .xm files doing this, just this specific track.

Here is the details in bullet list form, for further clarification:

My browser is Mozilla Firefox, if that matters.

WKFO commented 1 year ago

Another occurrence is track id 113527. This one isn't an .xm, it is a .mod file.

orhun commented 1 year ago

pinging @Cthulhu2 in case he wants to debug this :3

Cthulhu2 commented 1 year ago

Upgrade OpenMPT? There is a couple changes in the 0.6.0, may be it's related:

  • libopenmpt can now detect infinite pattern loops and treats them as the song end. This means that setting a repeat count other than -1 now always guarantees that playback will eventually end. The song loop counter is decremented each time it ends up at the start of the infinite loop, so the song does not restart from the beginning even if the repeat count is not 0.
  • openmpt::module::set_position_seconds() accuracy has been improved for modules with pattern loops.