orhun / CoolModFiles

A web player that plays some cool MOD files randomly 🎶
https://CoolModFiles.com
GNU General Public License v3.0
131 stars 12 forks source link

fix: Fix skipping ahead via upgrading OpenMPT to 0.7.0 (#52) #53

Closed Cthulhu2 closed 1 year ago

Cthulhu2 commented 1 year ago

OpenMPT Lib v0.5.1 -> v0.7.0 OpenMPT Core v1.41.1.2 -> v1.49.0.19

fixes #52

vercel[bot] commented 1 year ago

Someone is attempting to deploy a commit to a Personal Account owned by @orhun on Vercel.

@orhun first needs to authorize it.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cool-mod-files ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2023 10:24pm
orhun commented 1 year ago

Great PR, thanks for this! 💖

Calling out @WKFO for testing, it is a core library so we need to make sure everything works properly.

See the preview here: https://cool-mod-files-git-fork-cthulhu2-fix-skip-ahead-52-orhun.vercel.app/

Cthulhu2 commented 1 year ago

I did try to build libopenmpt, but it crashed on _openmpt_module_create_from_memory. May be it was an unstable branch... Finally, I tumbled to check out the modarchive.org. The libopenmpt from this urls:

orhun commented 1 year ago

So are we using the same libopenmpt as modarchive?

Cthulhu2 commented 1 year ago

Yes.

$ wget https://modarchive.org/style/js/libopenmpt.js
...
$ sha256sum ./libopenmpt.js 
95abd981c41474e2f0a08f74619cd83c59fc30883426fdbd0b7ddfdde953de51  ./libopenmpt.js
$ sha256sum ./public/libopenmpt.js 
95abd981c41474e2f0a08f74619cd83c59fc30883426fdbd0b7ddfdde953de51  ./public/libopenmpt.js

$ wget https://modarchive.org/style/js/libopenmpt.wasm
...
$ sha256sum ./libopenmpt.wasm 
c52f1143ae789e2a7222259951c0785fca89fd821f0c153cb1617b574fb26b73  ./libopenmpt.wasm
$ sha256sum ./public/bin/libopenmpt.wasm 
c52f1143ae789e2a7222259951c0785fca89fd821f0c153cb1617b574fb26b73  ./public/bin/libopenmpt.wasm