search

orhun / CoolModFiles

A web player that plays some cool MOD files randomly 🎶
https://CoolModFiles.com
GNU General Public License v3.0
131 stars 12 forks source link

feat: Add volume icon and percent label (#2) #55

Closed Cthulhu2 closed 11 months ago

vercel[bot] commented 1 year ago

Someone is attempting to deploy a commit to a Personal Account owned by @orhun on Vercel.

@orhun first needs to authorize it.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cool-mod-files ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 11, 2023 11:09am
orhun commented 1 year ago

Should we maybe remove the volume icon and use text only? I think it looks a bit crowded right now:

cap

What do you think?

Cthulhu2 commented 1 year ago

Huh, maybe... But the icon brings a bit symmetry with right handed pair of buttons. And it needs to increase distance to QuestionButton. And the text can be placed on the top of slider to reduce density.

And what do you think about circular sliders? Something like this:

image

orhun commented 1 year ago

Huh, maybe... But the icon brings a bit symmetry with right handed pair of buttons. And it needs to increase distance to QuestionButton. And the text can be placed on the top of slider to reduce density.

Hmm, I'm not sure how that would look and what's the best design to choose here. Can you possibly share a mockup of that?

And what do you think about circular sliders? Something like this:

Definitely an intriguing idea + looks pretty good.

ping @WKFO for comment.

WKFO commented 1 year ago

First of all, good idea.

I think the volume icon should be there; because on the player, there is an indication as to what is what, except the volume control. If you don't want crowd, there is the small player, whose use I don't really see to be honest.

Circular slider looks cooler but may be slightly more cumbersome to use; because a lot of people can quickly tab in, aim at a straight slider and tab back out, but aiming the correct position on a circular slider may require more effort.

orhun commented 1 year ago

Yeah, it looks definitely better with the last update, thanks @Cthulhu2!

Is there anything else needed to be done about this?

orhun commented 11 months ago

Can I get a final review on this @WKFO?

https://cool-mod-files-av0l769xd-orhun.vercel.app/

orhun commented 11 months ago

Works seamlessly, thanks a lot! @Cthulhu2