orhun / binsider

Analyze ELF binaries like a boss πŸ˜ΌπŸ•΅οΈβ€β™‚οΈ
https://binsider.dev/
Apache License 2.0
2.76k stars 61 forks source link

warning: the following packages contain code that will be rejected by a future version of Rust: bitflags v0.7.0 #61

Closed ngmisl closed 1 month ago

ngmisl commented 1 month ago

future incompatibility warning

orhun commented 1 month ago

I don't get this locally. Which platform are you on + what version of Rust are you using?

ngmisl commented 1 month ago

The currently active rustc version is rustc 1.81.0 (eeb90cda1 2024-09-04) Linux

orhun commented 1 month ago

I am able reproduce with 1.81.0 - not sure how to fix this though. I tried cargo update but still getting the same warning.

orhun commented 1 month ago

The issue comes from either nix (bitflags) or termbg (async-std) I think.

cjrh commented 1 month ago

Looks like it comes via lurk-cli

β”œβ”€β”€ lurk-cli v0.3.8
β”‚   β”œβ”€β”€ anyhow v1.0.86
β”‚   β”œβ”€β”€ atty v0.2.14
β”‚   β”‚   └── libc v0.2.158
β”‚   β”œβ”€β”€ byteorder v1.5.0
β”‚   β”œβ”€β”€ clap v4.5.18 (*)
β”‚   β”œβ”€β”€ comfy-table v7.1.1
β”‚   β”‚   β”œβ”€β”€ crossterm v0.27.0
β”‚   β”‚   β”‚   β”œβ”€β”€ bitflags v2.6.0
β”‚   β”‚   β”‚   β”œβ”€β”€ libc v0.2.158
β”‚   β”‚   β”‚   └── parking_lot v0.12.3 (*)
β”‚   β”‚   β”œβ”€β”€ strum v0.26.3 (*)
β”‚   β”‚   β”œβ”€β”€ strum_macros v0.26.4 (proc-macro) (*)
β”‚   β”‚   └── unicode-width v0.1.14
β”‚   β”œβ”€β”€ console v0.15.8 (*)
β”‚   β”œβ”€β”€ libc v0.2.158
β”‚   β”œβ”€β”€ linux-personality v1.0.0
β”‚   β”‚   β”œβ”€β”€ bitflags v0.7.0                               <--------------- HERE
β”‚   β”‚   └── libc v0.2.158
β”‚   β”œβ”€β”€ nix v0.29.0
β”‚   β”‚   β”œβ”€β”€ bitflags v2.6.0
β”‚   β”‚   β”œβ”€β”€ cfg-if v1.0.0
β”‚   β”‚   └── libc v0.2.158
TornaxO7 commented 1 month ago

And looks like as if linux-personality hasn't got any changes for 8 years

cjrh commented 1 month ago

That package is quite small and apparently stable, so vendoring could be an option here.

https://github.com/jeandudey/linux-personality/blob/master/src/lib.rs

jeandudey commented 1 month ago

There's also this on the nix crate:

https://docs.rs/nix/latest/nix/sys/personality/index.html

But I can still update the linux-personality crate if you prefer so.

jeandudey commented 1 month ago

I've released 2.0.0 of the crate in any case.

TornaxO7 commented 1 month ago

Awesome!

peepoAwesome

orhun commented 1 month ago

Wow, thank you @jeandudey!