orhun / binsider

Analyze ELF binaries like a boss πŸ˜ΌπŸ•΅οΈβ€β™‚οΈ
https://binsider.dev/
Apache License 2.0
2.76k stars 61 forks source link

Godzie44/run as widget #73

Open godzie44 opened 1 month ago

godzie44 commented 1 month ago

Description of change

Tui component has been removed. Integration with third-party applications has been simplified.

orhun commented 1 month ago

Can you go through your changes a bit and tell me about the rationales? Comparing widget.rs with the current demo.rs, I don't see how this makes things more simple πŸ€”

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 111 lines in your changes missing coverage. Please review.

Project coverage is 3.31%. Comparing base (19bea73) to head (8395b85).

Files with missing lines Patch % Lines
src/lib.rs 0.00% 70 Missing :warning:
src/tui/mod.rs 0.00% 18 Missing :warning:
src/tui/event.rs 0.00% 10 Missing :warning:
src/file.rs 0.00% 9 Missing :warning:
src/app.rs 0.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #73 +/- ## ======================================== - Coverage 3.31% 3.31% -0.00% ======================================== Files 19 19 Lines 2419 2422 +3 ======================================== Hits 80 80 - Misses 2339 2342 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

godzie44 commented 1 month ago

Currently it's make possible to handle restart event correctly - because now, only this event requires user implementation. Tui component removed, and manipulation with terminal at restart, or dynamic analysis removed too, I hope that this will allow to integrate binsider nto existing tui's like window-in-window.

About simplification - if you compare with demo.rs, then all event processing is now hidden in the handle_event function, and only cumbersome initialization remains (it can be hidden in the next step of refactoring)

orhun commented 1 month ago

I see. I think it would be easier to review this after seeing the usage in action. So if you can incorporate these changes in #45, I can take a look again :)

godzie44 commented 1 month ago

You can check this out now

godzie44 commented 2 weeks ago

@orhun please check this now