Open godzie44 opened 1 month ago
Can you go through your changes a bit and tell me about the rationales? Comparing widget.rs
with the current demo.rs
, I don't see how this makes things more simple π€
Attention: Patch coverage is 0%
with 111 lines
in your changes missing coverage. Please review.
Project coverage is 3.31%. Comparing base (
19bea73
) to head (8395b85
).
Files with missing lines | Patch % | Lines |
---|---|---|
src/lib.rs | 0.00% | 70 Missing :warning: |
src/tui/mod.rs | 0.00% | 18 Missing :warning: |
src/tui/event.rs | 0.00% | 10 Missing :warning: |
src/file.rs | 0.00% | 9 Missing :warning: |
src/app.rs | 0.00% | 4 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Currently it's make possible to handle restart event correctly - because now, only this event requires user implementation. Tui
component removed, and manipulation with terminal at restart, or dynamic analysis removed too, I hope that this will allow to integrate binsider nto existing tui's like window-in-window.
About simplification - if you compare with demo.rs, then all event processing is now hidden in the handle_event
function, and only cumbersome initialization remains (it can be hidden in the next step of refactoring)
I see. I think it would be easier to review this after seeing the usage in action. So if you can incorporate these changes in #45, I can take a look again :)
You can check this out now
@orhun please check this now
Description of change
Tui
component has been removed. Integration with third-party applications has been simplified.