orhun / binsider

Analyze ELF binaries like a boss 😼🕵️‍♂️
https://binsider.dev/
Apache License 2.0
2.76k stars 61 forks source link

fix(flake): add missing meta section to flake #74

Closed ch4og closed 1 month ago

ch4og commented 1 month ago

Description of change

This adds meta section which is needed for example to show description of a package

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 3.33%. Comparing base (aba6112) to head (70e747d). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #74 +/- ## ======================================== - Coverage 3.34% 3.33% -0.01% ======================================== Files 19 19 Lines 2399 2407 +8 ======================================== Hits 80 80 - Misses 2319 2327 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

orhun commented 1 month ago

btw, do you know if there are any GitHub actions (or can we hack something together) to test the Nix builds in CI?

ch4og commented 1 month ago

Easiest approach is installing nix package manager onto action

I'll look into it now and will create PR / give you feedback

orhun commented 1 month ago

perfect, thanks!

ch4og commented 1 month ago

I did an action that builds flake https://github.com/orhun/binsider/commit/50f6acd686acdb489f150aa3593b9da0250a74be but I have no idea how to use rust-cache with nix building system.

After an hour of searching a way I found nothing.
Without rust-cache build takes 5+mins. https://github.com/ch4og/binsider/actions/runs/11232508090/job/31224245945

The only way I know to fix this is complex full rewrite of flake, that will build cargo crate. I don't have enough knowlege and desire to do it.

Should I create a PR with this half success?

orhun commented 1 month ago

Ah, for sure, please go ahead and create a draft PR. I can ping some Nix people for further help :)

Thanks for your effort on this! ❤️