Open XXMA16 opened 1 week ago
Attention: Patch coverage is 0%
with 58 lines
in your changes missing coverage. Please review.
Project coverage is 3.25%. Comparing base (
09137d2
) to head (311261d
).
Files with missing lines | Patch % | Lines |
---|---|---|
src/elf/symbols.rs | 0.00% | 49 Missing :warning: |
src/tui/state.rs | 0.00% | 8 Missing :warning: |
src/tui/command.rs | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Looks good to me! Thanks for implementing! <3
Can we also use lowercase s
for the sort?
Should I make a Sort trait in order to have less repeated code?
Sounds good. I'm curious how a trait would look like though. What is in your mind?
Should info_index be bound to Static Analysis instead of State?
Yup, sounds good. Feel free to make the refactor.
The option to sort is shown for Dynamic and Relocations too, even though it doesn't do anything.
Would be nice to disable that somehow.
Description of change
Made the Symbols from Static Analysis sortable by name and address. The sorting modes can be cycled with
S
.Concerns
Should I make a
Sort
trait in order to have less repeated code? Shouldinfo_index
be bound to Static Analysis instead of State? The option to sort is shown forDynamic
andRelocations
too, even though it doesn't do anything.partially closes #22