Closed mjhipp closed 3 years ago
Describe the bug Fails to parse conventional commit messages made from squashing and merging Pull Requests if there is no body message.
To Reproduce Steps to reproduce the behavior:
TRACE
Expected behavior These PR commit messages can be parsed as normal
Screenshots/Logs I did these steps on a fork of this repo: https://github.com/mjhipp/git-cliff
Created pull requests, and merged them:
one of them I added an extra message:
The git log:
Then tried to create a changelog:
It is not the parenthesis or #, because it works if I commit directly:
#
If I perform an interactive rebase and "reword" the commits, without actually changing anything, the commits can then be parsed:
System (please complete the following information):
ubuntu-latest
git-cliff-action
0.1.0
git-cliff-action@v1
Additional context Sorry for the long post! This is a great tool and I would really like to be able to use it with squashed PRs!
This has already been fixed upstream! https://github.com/crate-ci/git-conventional/releases/tag/v0.10.1
https://github.com/crate-ci/git-conventional/issues/12#issuecomment-912587335
https://github.com/orhun/git-cliff/blob/ae8821aaa537f597762206647c18e9ac69289b6a/git-cliff-core/Cargo.toml#L31-L33
Thanks for investigating/reporting this! I'll release a new version to fix this soon.
Describe the bug Fails to parse conventional commit messages made from squashing and merging Pull Requests if there is no body message.
To Reproduce Steps to reproduce the behavior:
TRACE
messages and the missing commits from the changelogExpected behavior These PR commit messages can be parsed as normal
Screenshots/Logs I did these steps on a fork of this repo: https://github.com/mjhipp/git-cliff
Created pull requests, and merged them:
one of them I added an extra message:
The git log:
Then tried to create a changelog:
It is not the parenthesis or
#
, because it works if I commit directly:If I perform an interactive rebase and "reword" the commits, without actually changing anything, the commits can then be parsed:
System (please complete the following information):
ubuntu-latest
forgit-cliff-action
0.1.0
andgit-cliff-action@v1
Additional context Sorry for the long post! This is a great tool and I would really like to be able to use it with squashed PRs!