orhun / kermit

A VTE-based, simple and froggy terminal emulator 🐸
GNU General Public License v3.0
134 stars 8 forks source link

Themeing #10

Closed travankor closed 4 years ago

travankor commented 4 years ago

Can you add a way to customize theme options? Something so that base-16 works? Example of how the format can look.

orhun commented 4 years ago

So, are you suggesting to update the k3rmit config format according to the base-16?

travankor commented 4 years ago

Actually, I missed the existing themeing colours. But can you add 256 color support (tput colors says 256)?

orhun commented 4 years ago

Can you give an example about the color scheme you want to use?

travankor commented 4 years ago

I tried to add

# extended base16 colors
color16 0xfe8019
color17 0xd65d0e
color18 0x3c3836
color19 0x504945
color20 0xbdae93
color21 0xebdbb2  

but I get fish: 'k3rmit' terminated by signal SIGSEGV (Address boundary error)

orhun commented 4 years ago

okay I see, it's a bug due to the fixed size of termPalette variable. I'll check if GDK supports extended colors and keep this issue updated.

orhun commented 4 years ago

unfortunately, vte_terminal_set_colors function does not support extended colors.

(k3rmit.o): VTE-CRITICAL **: 13:10:33.614: void vte_terminal_set_colors(VteTerminal*, const GdkRGBA*, const GdkRGBA*, const GdkRGBA*, gsize): assertion '(palette_size == 0) || (palette_size == 8) || (palette_size == 16) || (palette_size == 232) || (palette_size == 256)' failed

I'll keep looking for alternatives.

travankor commented 4 years ago

What termite does if this helps

orhun commented 4 years ago

I've changed the config file format and updated the palette size to 256. Can you try the extended colors now?

orhun commented 4 years ago

https://github.com/orhun/base16-k3rmit

travankor commented 4 years ago

Thanks! This works now.