orhun / kermit

A VTE-based, simple and froggy terminal emulator 🐸
GNU General Public License v3.0
138 stars 9 forks source link

Feature Request: Open new window in current PWD #23

Closed jzbor closed 5 months ago

jzbor commented 7 months ago

Hi, I am considering switching to kermit from my own vte implementation, but I really depend on one feature: I use Ctrl+Return to spawn a new window with the working directory set to the current one. You can find the implementation here. The main functionality is provided by vte through vte_terminal_get_current_directory_uri().

Also is it possible to remap the default keys (i.e. use a different key for one of the default actions or remove a binding for one of the default actions)?

Thanks for the great work!

orhun commented 7 months ago

Hello! kermit is not under active development however I'd love to have this feature in! Would you be possibly interested in contributing?

The key bindings are not fully configurable, see .config/kermit.conf.

jzbor commented 7 months ago

Yes I would be open to contributing.

I was also thinking about implementing more configurable keybindings: Something like bindi for internal bindings and allowing for individual modifiers. Would you be open to such changes as well? Should I open a separate issue/draft PR?

jzbor commented 7 months ago

I have created two pull requests regarding the two features. If you want to accept these contributions I will also make sure to add documentation.

As for the internal-keybindings thing: The way it is implemented it does not contain any defaults anymore and is therefore also a breaking change. This could be worked around if desired, but maybe this is the cleanest option.

orhun commented 7 months ago

I like the both PRs! (no backdoors though, what!??)

We can move forward with them, so please add docs! 🚀

I will try them out myself in the following days.

As for the internal-keybindings thing: The way it is implemented it does not contain any defaults anymore and is therefore also a breaking change.

Does it mean we need to include the defaults in the config?

jzbor commented 7 months ago

I have now added docs and rebased #25 onto #24.

Does it mean we need to include the defaults in the config?

Yes. It would either have to be added in the code or in the suggested config file.