search

orhun / kermit

A VTE-based, simple and froggy terminal emulator 🐸
GNU General Public License v3.0
134 stars 8 forks source link

Make internal keybindings configurable via config file (bindi) #25

Closed jzbor closed 4 months ago

jzbor commented 5 months ago

See also #23

jzbor commented 5 months ago

Now based on #24

orhun commented 5 months ago

Looks really good! I'm thinking if we should make the bindi commands case insensitive for the sake of simplifying the config. What do you think?

jzbor commented 5 months ago

Oh my bad, I think it is already implemented that way. I fixed it in the config also.

orhun commented 4 months ago

Can we not base this on #24 just for the sake of moving forward? I'd like to get this feature in 🐻

jzbor commented 4 months ago

Yes, will do

jzbor commented 4 months ago

Can we not base this on #24 just for the sake of moving forward? I'd like to get this feature in 🐻

Done

orhun commented 4 months ago

Just tested this and I guess the default key bindings are not available we provide the configuration via -c option, right? Is there a way to embed defaults into the code? What do you think?

jzbor commented 4 months ago

Just tested this and I guess the default key bindings are not available we provide the configuration via -c option, right? Is there a way to embed defaults into the code? What do you think?

I have now implemented default key bindings

orhun commented 4 months ago

LGTM! Just one last comment 🐻

orhun commented 4 months ago

I will check out your comment in #24 soon! I'm planning to get that one in and create a release 🐻