orhun / rustypaste

A minimal file upload/pastebin service.
https://blog.orhun.dev/blazingly-fast-file-sharing
MIT License
760 stars 47 forks source link

test(fixtures): support `fixtures` on `macOS` #200

Closed DDtKey closed 9 months ago

DDtKey commented 9 months ago

Description

Change fixtures to support macos as well as linux

Motivation and Context

How Has This Been Tested?

Fixtures works on macOS and should pass CI (on lunux)

Changelog Entry

### Changed

- Support fixtures on macOS

Types of Changes

Checklist:

DDtKey commented 9 months ago

Though it might be broken anytime without CI, so if it makes sense I can add a matrix with OS

Probably it's not a desired approach to time fixtures, taking other platforms into account

codecov-commenter commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3e34206) 70.23% compared to head (de8286e) 70.23%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #200 +/- ## ======================================= Coverage 70.23% 70.23% ======================================= Files 11 11 Lines 598 598 ======================================= Hits 420 420 Misses 178 178 ``` | [Flag](https://app.codecov.io/gh/orhun/rustypaste/pull/200/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Orhun+Parmaks%C4%B1z) | Coverage Δ | | |---|---|---| | [unit-tests](https://app.codecov.io/gh/orhun/rustypaste/pull/200/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Orhun+Parmaks%C4%B1z) | `70.23% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Orhun+Parmaks%C4%B1z#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

orhun commented 9 months ago

Yeah, I think it is a good idea to add a matrix here:

https://github.com/orhun/rustypaste/blob/3e342068840ba2ba5857deb9e4bacf80389dae65/.github/workflows/ci.yml#L47