fix(auth): remove excessive warning and typo

tessus commented 8 months ago

Description

Iff one doesn't use auth tokens, their log is spammed with warning messages. This change removes the warning message.

It also fixes a small typo.

Motivation and Context

Fixes #209

How Has This Been Tested?

cargo test fixtures

Changelog Entry

Types of Changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation (no code change)
[ ] Refactor (refactoring production code)
[ ] Other

Checklist:

[x] My code follows the code style of this project.
[ ] I have updated the documentation accordingly.
[x] I have formatted the code with rustfmt.
[x] I checked the lints with clippy.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f905648) 70.16% compared to head (e242104) 70.11%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #210 +/- ## ========================================== - Coverage 70.16% 70.11% -0.05% ========================================== Files 11 11 Lines 610 609 -1 ========================================== - Hits 428 427 -1 Misses 182 182 ``` | [Flag](https://app.codecov.io/gh/orhun/rustypaste/pull/210/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Orhun+Parmaks%C4%B1z) | Coverage Δ | | |---|---|---| | [unit-tests](https://app.codecov.io/gh/orhun/rustypaste/pull/210/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Orhun+Parmaks%C4%B1z) | `70.11% <100.00%> (-0.05%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Orhun+Parmaks%C4%B1z#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tessus commented 8 months ago

Something's off with the shuttle deploy action. But I don't think a shuttle version should be deployed when creating a PR. Or is this a test shuttle instance (not prod)?

orhun commented 8 months ago

Something's off with the shuttle deploy action.

Yeah, it shouldn't deploy. I think the following condition is not working:

      - name: Deploy
        if: |
          ${{ startsWith(github.event.ref, 'refs/tags/v') ||
            github.event_name == 'workflow_dispatch' ||
            steps.changes.outputs.manifest == 'true'
          }}

Are you interested in looking into it by any chance?

tessus commented 8 months ago

I would be, but I do not have a shuttle account. Not sure how to test any changes on my fork. I might be able to look into it within the next few weeks (I will also have to create a shuttle account and API key). Although during the holidays it's always busy.

orhun commented 8 months ago

Alright, no problem. I think it is just enough to test that condition on GitHub Actions. I will just create an immediate release for the changes in this PR now and we can look into that later I guess.

orhun / rustypaste