Closed tessus closed 6 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
8de2450
) 70.11% compared to head (5056916
) 70.11%.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I thought about it for a while and it won't break anything.
But I see an issue that has nothing to do with this or the previous PRs: One can upload multiple files with the same name, but that was already possible with the curl -F "file=@x.txt;filename=wow.nice"
command when random_url
was not set. This case was never taken into consideration.
We can look into this in a separate discussion or issue.
I created a separate discussion #241
Can you think of any edge cases that this would break backwards compatibility?
A bit more info:
If multiple files with the same name are on the server, the file with the longest expiry timestamp will be returned when accessing the file via curl <server>/file.txt
Previously a different file was returned. Which one is not entirely clear depending on expiration but not yet cleaned from disk, and so on.
But this was never a defined behavior anyway, thus no breaking change.
Description
The
glob_match_file
function returns the wrong entry.glob
yields paths in alphabetical order. We want the file with the longest expiry date/time.Motivation and Context
fixes #218
How Has This Been Tested?
Changelog Entry
Types of Changes
Checklist: