orhun / rustypaste

A minimal file upload/pastebin service.
https://blog.orhun.dev/blazingly-fast-file-sharing
MIT License
757 stars 47 forks source link

fix(server): improve logging for deleted file #235

Closed tessus closed 7 months ago

tessus commented 7 months ago

Description

This change converts a path to a string.

Motivation and Context

Before

<TIMESTAMP> INFO rustypaste::server: deleted file: Path("file-to-delete.txt")

After

<TIMESTAMP> INFO rustypaste::server: deleted file: "file-to-delete.txt"

How Has This Been Tested?

Changelog Entry

### Changed

- Improved server side logging when deleting a file

Types of Changes

Checklist:

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8de2450) 70.11% compared to head (40559f7) 70.11%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #235 +/- ## ======================================= Coverage 70.11% 70.11% ======================================= Files 11 11 Lines 609 609 ======================================= Hits 427 427 Misses 182 182 ``` | [Flag](https://app.codecov.io/gh/orhun/rustypaste/pull/235/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Orhun+Parmaks%C4%B1z) | Coverage Δ | | |---|---|---| | [unit-tests](https://app.codecov.io/gh/orhun/rustypaste/pull/235/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Orhun+Parmaks%C4%B1z) | `70.11% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Orhun+Parmaks%C4%B1z#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.