Closed tessus closed 6 months ago
The file https://upload.wikimedia.org/wikipedia/en/a/a9/Example.jpg
has changed and thus the sha256 is wrong. I am wondering if we can find a file that doesn't change - ever. Hmm, maybe something in a repo.
Unfortunately the rustypaste logo is 224,372 bytes while the Example jpg is currently 25,503 bytes.
I'll think of something.
Ok, so all your PNGs in your repos are around 200-250k. Wikipedia does not have permanent links, but they archived the previous one and this link should never change. I'll update the link, so the hash stays the same.
Sounds good to me!
Small problem. for some reason the hash even changed for the old file (different link, but same file). I suspect that the sha256_digest
function in util.rs
takes the filename into account. Weird, I don't think this should behave that way.
I'm thinking if we should just remove those tests altogether or gate them behind a feature flag. They have been failing spuriously for some time.
Which tests? all of the ones in paste.rs
? That would be rather brutal.
Btw, I have the fix for the same filename ready. Just waiting for the other PR to be merged, because the file op would then require an .await
.
One more thing: it seems that the auto-merge for the depandabot PRs doesn't work. Neither here, nor in the cli repo.
Which tests? all of the ones in paste.rs? That would be rather brutal.
I meant only the ones that require fetching stuff from a remote server (i.e. Wikipedia) - but I guess they are fine.
One more thing: it seems that the auto-merge for the depandabot PRs doesn't work. Neither here, nor in the cli repo.
Do you think we should have Mergify? What do you think of auto-merging PRs?
I meant only the ones that require fetching stuff from a remote server (i.e. Wikipedia) - but I guess they are fine.
Ah, ok. Yep, they should be fine now. Well, it's always a risk, e.g. if there's a connection issue from the runner, which happens now and then. But how would you test a remote fetch? We could setup a local web service that fetches a local file. But that might be an overkill.
Do you think we should have Mergify?
It's setup in rustypaste-cli, but doesn't seem to work.
What do you think of auto-merging PRs?
Complex topic. It entails a certain risk, although in can be minimized. If the automerge only happens, if all tests pass successfully, then it should be fine. If there's also a way to limit it to minor and patch upgrades, it's even better. The problem is that you have a lot of projects and many of them have dependencies. Manually managing all of them is a lot of work and you can't test all of them yourself. Thus I am afraid, even if auto-merging is not the 100% most perfect solution, it might be the only viable one.
P.S.: I am only talking about dependabot PRs.
Yeah, fair point. I think I will set up auto merging again soon. Can you shoot me an issue so that I don't forget? 🙏🏼
Steps to reproduce:
This is what I get on macOS and on Linux: