orhun / rustypaste

A minimal file upload/pastebin service.
https://blog.orhun.dev/blazingly-fast-file-sharing
MIT License
757 stars 47 forks source link

test(upload): update the hash of the example file #254

Closed tessus closed 6 months ago

tessus commented 6 months ago

Description

The file https://upload.wikimedia.org/wikipedia/en/a/a9/Example.jpg was replaced by a different version on March 1st.

I checked, the old file still exists and the hash is the same, but unfortunately the util::sha256_digest seems to take the filename into account, because I tried to replace the link, but the hash changed in the rustypaste tests as well. When I check the hash on the commandline with shasum, it's actually the same though.

Since the hash changes either way, I just updated the hash, instead of link and hash.

Motivation and Context

fixes #253

How Has This Been Tested?

cargo test fixtures

Changelog Entry

### Fixed

- update hash in tests, since the file changed at source

Types of Changes

Checklist:

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.42%. Comparing base (db971e6) to head (c6b4a41). Report is 2 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #254 +/- ## ========================================== - Coverage 70.88% 70.42% -0.46% ========================================== Files 11 11 Lines 625 629 +4 ========================================== Hits 443 443 - Misses 182 186 +4 ``` | [Flag](https://app.codecov.io/gh/orhun/rustypaste/pull/254/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Orhun+Parmaks%C4%B1z) | Coverage Δ | | |---|---|---| | [unit-tests](https://app.codecov.io/gh/orhun/rustypaste/pull/254/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Orhun+Parmaks%C4%B1z) | `70.42% <ø> (-0.46%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Orhun+Parmaks%C4%B1z#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

orhun commented 6 months ago

It's fun to see wikipedia getting updated