Closed tessus closed 5 months ago
Attention: Patch coverage is 83.33333%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 70.21%. Comparing base (
fa5105d
) to head (1266766
).
Files | Patch % | Lines |
---|---|---|
src/paste.rs | 83.33% | 1 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
Currently it is possible to upload files with the same name. This is undefined behavior. e.g. which file should be returned when accessing it?
To solve this problem this change introduces a check whether a file (that hasn't expired) alredy exists with the same name. If so, an error will be returned.
Motivation and Context
see https://github.com/orhun/rustypaste/discussions/241
I am opening this PR now, because I want to check, whether the test that fails in #246 also fails with this one.
Depending on which PR is merged first, a change will be required to add an
.await
to theglob_match_file
call.How Has This Been Tested?
Changelog Entry
Types of Changes
Checklist: